Keep command hook version internal while fixing related Arc.React test regressions by Copilot · Pull Request #2230 · Cratis/Arc

Copilot · 2026-05-21T09:09:22Z

Summary

This PR keeps the command version counter internal to CommandForm, adds regression coverage for useCommand scope registration, and fixes related Arc.React test regressions uncovered by CI in the useChangeStream suite.

Added

Added regression coverage for generated-style command .use() registration inside CommandScope, including a guard against React render-phase update warnings (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Added test isolation for useChangeStream specs by providing a fresh query cache per test render (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Changed

Moved command version tracking into CommandForm, where it is used for rerenders and auto server validation (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Updated the command proxy template and sample generated command hook signatures to match the public 3-tuple useCommand API (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Updated useChangeStream regression specs to wait for subscription callback registration before pushing query results (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Fixed

Fixed the public useCommand contract so generated command hooks no longer expose an internal version value (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Fixed typing drift between generated command hooks and the current useCommand return shape (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Fixed CI regressions in Arc.React useChangeStream tests caused by shared QueryInstanceCache state between specs (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)
Fixed Arc.React command regression tests to avoid React act(...) warning failures in CI (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Removed

Removed the exposed version number from the public useCommand tuple and generated command .use() signatures (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Security

No security changes (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Deprecated

No deprecations (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/14babc5a-7987-411f-add8-ea098bf25257 Co-authored-by: einari <134365+einari@users.noreply.github.com>

github-actions · 2026-05-21T09:55:45Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.24.19

einari · 2026-05-21T10:48:25Z

@copilot Is there a reason to return the version number at all? We're just using to cause a re-render, I don't see any value in exposing it to the outside world. Unless you're seeing something

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/0986ad34-f238-4e47-9e6f-ea7a46a3c2a6 Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot · 2026-05-21T10:58:04Z

@copilot Is there a reason to return the version number at all? We're just using to cause a re-render, I don't see any value in exposing it to the outside world. Unless you're seeing something

No — I agree it shouldn’t be part of the public API. I moved the version tracking into CommandForm and changed useCommand/generated .use() back to the 3-value tuple in 291d857.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

example.com
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run commands/for_useCommand/when_creating_instance.ts commands/for_useCommand/when_creating_instance_with_initial_values.ts commands/for_useCommand/when_creating_instance_without_optional_context_values.ts commands/for_useCommand/when_registering_with_command_scope.ts commands/CommandForm/for_CommandForm/when_field_value_changes.ts commands/CommandForm/for_CommandForm/when_autoServerValidate_is_true.ts commands/CommandForm/for_CommandForm/when_autoServerValidate_with_throttle.ts (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

github-actions · 2026-05-21T13:29:33Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.24.23

einari · 2026-05-21T14:08:02Z

@copilot Either you didn't look into fixing the regressions, or the CI has not run - its the same failures I see: https://productionresultssa3.blob.core.windows.net/actions-results/ce633aa2-e489-40e3-ba5c-d7c19719ca7a/workflow-job-run-035b4433-0bbb-5099-8a64-61390b99b273/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-05-21T14%3A17%3A42Z&sig=SLnijsEh8mph%2BPWtBNPhMowHn8mmn7l6DK8y1LjSjrE%3D&ske=2026-05-21T15%3A33%3A27Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-05-21T11%3A33%3A27Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-05-21T14%3A07%3A37Z&sv=2025-11-05

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/d20d73f2-0a2f-4df2-a8be-38bc97ede375 Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot · 2026-05-21T14:19:15Z

@copilot Either you didn't look into fixing the regressions, or the CI has not run - its the same failures I see: https://productionresultssa3.blob.core.windows.net/actions-results/ce633aa2-e489-40e3-...

Fixed in d48cfef. I addressed the React act(...) regression in the throttled CommandForm spec and isolated the useChangeStream specs with a fresh query cache per render so they no longer share stale subscriptions. I re-ran yarn workspace @cratis/arc.react ci locally and it now passes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

example.com
- Triggering command: /opt/hostedtoolcache/node/24.15.0/x64/bin/node /opt/hostedtoolcache/node/24.15.0/x64/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot · 2026-05-21T14:26:54Z

@copilot Either you didn't look into fixing the regressions, or the CI has not run - its the same failures I see: https://productionresultssa3.blob.core.windows.net/actions-results/ce633aa2-e489-40e3-...

Fixed in d48cfef. I reproduced the failing JavaScript Build locally, isolated the useChangeStream specs from shared QueryInstanceCache state, and re-ran yarn workspace @cratis/arc.react ci successfully (132 files / 339 tests). The latest JavaScript Build run for d48cfef is also green.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

example.com
- Triggering command: /opt/hostedtoolcache/node/24.15.0/x64/bin/node /opt/hostedtoolcache/node/24.15.0/x64/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run (dns block)
- Triggering command: /opt/hostedtoolcache/node/24.15.0/x64/bin/node /opt/hostedtoolcache/node/24.15.0/x64/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run conntrack --ctstate INVALID,NEW -j DROP (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

github-actions · 2026-05-21T14:28:36Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.24.26

Co-authored-by: einari <134365+einari@users.noreply.github.com>

…0-2232 Consolidate PRs #2229, #2230, and #2232

Initial plan

7c85bdc

Copilot AI assigned Copilot and einari May 21, 2026

Copilot started work on behalf of einari May 21, 2026 09:09 View session

Copilot AI linked an issue May 21, 2026 that may be closed by this pull request

useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227

Closed

test: add useCommand command scope regression coverage

ed66dd2

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/14babc5a-7987-411f-add8-ea098bf25257 Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix useCommand synchronous call during render~~ Align generated command hooks with useCommand scope registration behavior May 21, 2026

Copilot finished work on behalf of einari May 21, 2026 09:29

Copilot AI requested a review from einari May 21, 2026 09:29

Copilot started work on behalf of einari May 21, 2026 10:48 View session

refactor: keep command version internal to command form

291d857

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/0986ad34-f238-4e47-9e6f-ea7a46a3c2a6 Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot AI changed the title ~~Align generated command hooks with useCommand scope registration behavior~~ Keep command hook version internal while covering useCommand scope registration behavior May 21, 2026

Copilot finished work on behalf of einari May 21, 2026 10:59

Copilot started work on behalf of einari May 21, 2026 14:08 View session

test: stabilize command and change stream regressions

d48cfef

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/d20d73f2-0a2f-4df2-a8be-38bc97ede375 Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot AI changed the title ~~Keep command hook version internal while covering useCommand scope registration behavior~~ Keep command hook version internal while fixing related Arc.React test regressions May 21, 2026

Copilot finished work on behalf of einari May 21, 2026 14:20

Copilot finished work on behalf of einari May 21, 2026 14:28

Copilot AI added a commit that referenced this pull request May 21, 2026

Consolidate PRs #2229 #2230 and #2232

1bc9c1f

Co-authored-by: einari <134365+einari@users.noreply.github.com>

Copilot AI mentioned this pull request May 21, 2026

Consolidate PRs #2229, #2230, and #2232 #2233

Merged

einari merged commit c711f91 into main May 21, 2026
10 of 13 checks passed

einari added a commit that referenced this pull request May 21, 2026

Merge pull request #2233 from Cratis/copilot/consolidate-prs-2229-223…

2563a3b

…0-2232 Consolidate PRs #2229, #2230, and #2232

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep command hook version internal while fixing related Arc.React test regressions#2230

Keep command hook version internal while fixing related Arc.React test regressions#2230
einari merged 4 commits into
mainfrom
copilot/fix-usecommand-render-warning

Copilot AI commented May 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

einari commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

einari commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 21, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Added

Changed

Fixed

Removed

Security

Deprecated

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

einari commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

einari commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 21, 2026 •

edited

Loading

Copilot AI commented May 21, 2026 •

edited

Loading

Copilot AI commented May 21, 2026 •

edited

Loading

Copilot AI commented May 21, 2026 •

edited

Loading