Skip to content

Minor cleanup: fix small bugs and style issues in connect.sh#1

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/fix-e9455366-9af9-4ce0-9213-c4636df5770e
Draft

Minor cleanup: fix small bugs and style issues in connect.sh#1
Copilot wants to merge 4 commits intomainfrom
copilot/fix-e9455366-9af9-4ce0-9213-c4636df5770e

Conversation

Copy link

Copilot AI commented Sep 21, 2025

Applies a small set of targeted fixes to connect.sh without altering its overall structure or behaviour.

Changes Made

  • Missing newline after password prompt: Added echo after read -rs so subsequent output is not printed on the same line as the password input
  • Removed dead code: Deleted the misleading commented-out .env block that served no purpose
  • Consistent redirection: Changed >/dev/null to &>/dev/null on the docker ps check in the setup section to match the cleanup section
  • Standard function declaration: Changed function cleanup() to the POSIX-compatible cleanup() form

Testing

  • bash -n connect.sh — syntax check passes
  • shellcheck connect.sh — no warnings

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits September 21, 2025 10:08
…inability

Co-authored-by: DaTiC0 <13198638+DaTiC0@users.noreply.github.com>
Co-authored-by: DaTiC0 <13198638+DaTiC0@users.noreply.github.com>
Copilot AI changed the title [WIP] I want to refactore this code Major refactoring: Improve code quality, error handling, and maintainability Sep 21, 2025
Copilot AI requested a review from DaTiC0 September 21, 2025 10:11
Copy link
Owner

@DaTiC0 DaTiC0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring is overkill for this type of script @copilot

Co-authored-by: DaTiC0 <13198638+DaTiC0@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 13, 2026

This refactoring is overkill for this type of script @copilot

You're right. Rolled back to the original structure and applied only four minimal fixes in e7816be:

  • Added echo after the silent password read (missing newline was a real UX bug)
  • Removed the dead/misleading .env comment block
  • Made docker ps &>/dev/null consistent between the setup and cleanup sections
  • Changed function cleanup() to the standard cleanup() declaration form

No new functions, no logging infrastructure, no input validation loops.

Copilot AI changed the title Major refactoring: Improve code quality, error handling, and maintainability Minor cleanup: fix small bugs and style issues in connect.sh Mar 13, 2026
Copilot AI requested a review from DaTiC0 March 13, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants