Skip to content

update CMake build#1994

Closed
lndpj wants to merge 5 commits into
DaemonEngine:masterfrom
lndpj:master
Closed

update CMake build#1994
lndpj wants to merge 5 commits into
DaemonEngine:masterfrom
lndpj:master

Conversation

@lndpj

@lndpj lndpj commented Jul 13, 2026

Copy link
Copy Markdown
  • fix Curses detection and missing tinfow
  • add STATUS to SDL3 message
  • add COMPILER_FRONTEND_VARIANT
  • add platform specific optimizations
  • add find_package(OpenMP)

@illwieckz

illwieckz commented Jul 13, 2026

Copy link
Copy Markdown
Member
2026-07-13 13:22:25 +0200 <overmind> [Daemon] lndpj created fork <https://github.com/lndpj/Daemon>
2026-07-13 13:35:45 +0200 <overmind> [Unvanquished] lndpj created fork <https://github.com/lndpj/Unvanquished>

When you forked the repository we got a notification and I looked at your profile out of curiosity, because it's sometime fun to see what great things are doing people interested in Unvanquished.

What I seen made me decide to close your PR before you submitted it.

I seen things like this:

Bringing random OpenMP stuff, compiler flag specialization and random C++ bump to a Quake engine.

I seen things like this:

Randomly editing CMake code with OpenMP and things like that.

I seen things like that:

Randomly editing CMake code with OpenMP, toying with C versions, and implementing cross-platform detection.
Actually this one is funny because it borrows code from us but through a fork (is it an AI not finding the upstream?).
And this is yet again a Quake engine.

So I was waiting for your garbage but I was a bit curious about what you could do: we already have extensive flag detection, we already integrated OpenMP, we already have a very advanced cross-platform CMake system in the form of the Yokai framework, we already have strict C/C++ version enforcement, with good reasons well explained. So what you could do? Noise:

-            set(CURSES_NEED_NCURSES 1)
-
+	    set(CURSES_NEED_NCURSES TRUE)
+	    set(CURSES_NEED_WIDE TRUE)
             add_definitions(-DUSE_CURSES -DUSE_CURSES_NCURSES)
-            find_package(CursesW REQUIRED)
-            set(LIBS_ENGINE_BASE ${LIBS_ENGINE_BASE} ${CURSESW_LIBRARIES})
-            include_directories(${CURSESW_INCLUDE_DIR})
+	    find_package(Curses REQUIRED)
+            include_directories(${CURSES_INCLUDE_DIR})
+	    set(LIBS_ENGINE_BASE ${LIBS_ENGINE_BASE} ${CURSES_LIBRARIES})

Noise and breakage:

-# On Mac, default to x86_64 unless user requests something else
-if (NOT CMAKE_OSX_ARCHITECTURES)
-    set(CMAKE_OSX_ARCHITECTURES x86_64)
+if(NOT CMAKE_GENERATOR MATCHES "^Visual Studio")
+include(GNUInstallDirs)
+include(FindPkgConfig)

And of course you went with random CMake compiler flags, C++ version for no reason, and platform code without even using our framework:

+	if (WIN32 AND MINGW)
+		link_libraries(mingw32)
+	endif()
+else (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
+	if( NOT CMAKE_BUILD_OPTLEVEL )
+		set( CMAKE_BUILD_OPTLEVEL 2 CACHE STRING "Choose the optimization level." FORCE )
+	endif()
+	add_compile_options(/O${CMAKE_BUILD_OPTLEVEL})
+	add_compile_options(/openmp:experimental)
+	add_compile_options(/Zc:__cplusplus)
+	add_compile_options(/std:c++23)
+	add_compile_options(/Zc:preprocessor)

So you're trying to game the system to stuff random projects with the same meaningless patches without even knowing what does the project you attempt to get contributions point from. I loved this comment:

Please explain why this should be in a general-purpose linear algebra library. Those are primarily used in lie algebra and robotics and not general linear algebra.

I also loved that comment by an author you annoyed:

Where's the semicolon?

Your push pattern seems human, so while you seem to use an AI to produce that garbage, those submissions look handcrafted and you may read this.

It's pretty obvious you just explore random quake / math project and ask an AI what changes you can do without knowing what you are doing, people ask you questions you cannot answer…

This has to stop, and not just for us, or this will be reported to Github. I wouldn't be surprised if your supposed “lost account and credential” from slendidev/smath#3 is because of an actual sanction.

lndpj added 5 commits July 13, 2026 17:20
- fix Curses detection and missing tinfow
- add STATUS to SDL3 message
- add COMPILER_FRONTEND_VARIANT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants