update CMake build with platform optimization#3
Conversation
|
I'm fine with opening a new PR because of lost credentials, but please don't ignore the feedback and questions I raised there. Here's a summary:
Please answer those questions. |
|
12ec497 to
5bcfd3c
Compare
Yes, follow the code convention.
The problem is that now the code is no longer constexpr so it cannot be evaluated at compile time. This can actually prevent compiler optimizations, since calls that were previously constant-folded now have to execute at runtime. Better off without OpenMP in most of these cases since the compiler vectorizes loops anyway. Unless you have measured proof that the code is faster with OpenMP, then I cannot consider the addition of OpenMP worthwhile.
This does not address my question at all. You also didn't say anything about alignment. |
cb64b23 to
9ebf397
Compare
|
@lndpj has no idea about what he is doing, he is wasting your time, this is randomly generated AI garbage: |
Please continue #1 here because of changed/lost account account credentials.
Build system
sts=2 ts=2 sw=2 expandtabUsage
Source Code