Skip to content

Revert "update ECS fargate collector to use v4 endpoint"#24914

Merged
dd-mergequeue[bot] merged 1 commit intomainfrom
revert-23253-kangyi/ecs-fargate
Apr 22, 2024
Merged

Revert "update ECS fargate collector to use v4 endpoint"#24914
dd-mergequeue[bot] merged 1 commit intomainfrom
revert-23253-kangyi/ecs-fargate

Conversation

@paulcacheux
Copy link
Copy Markdown
Contributor

Reverts #23253

In the collector struct metav2 and metav4 are never initialized.

@paulcacheux paulcacheux requested a review from a team as a code owner April 22, 2024 13:32
@paulcacheux
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow bot commented Apr 22, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 22, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32592647 --os-family=ubuntu

@dd-devflow
Copy link
Copy Markdown

dd-devflow bot commented Apr 22, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit d8fc7e1 into main Apr 22, 2024
@dd-mergequeue dd-mergequeue bot deleted the revert-23253-kangyi/ecs-fargate branch April 22, 2024 15:15
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants