Skip to content

fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN#1046

Open
litianningdatadog wants to merge 1 commit intomainfrom
tianning.li/SLES-2729
Open

fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN#1046
litianningdatadog wants to merge 1 commit intomainfrom
tianning.li/SLES-2729

Conversation

@litianningdatadog
Copy link
Contributor

@litianningdatadog litianningdatadog commented Feb 24, 2026

JIRA: https://datadoghq.atlassian.net/browse/SLES-2729
Issue: #1000

Overview
When AWS Lambda freezes or terminates a function instance, the OS immediately closes all TCP sockets. The extension's proxy HTTP handler (handle_proxy) was mid-read on the request body — this read fails with error reading a body from connection and was logged at ERROR level, generating noise with no actionable signal.

This is expected Lambda lifecycle behaviour: the Lambda function completed successfully and nothing in the extension is broken. The ERROR level implies an extension fault, which misleads operators.

Change
Introduce a warn_response helper (mirroring the existing error_response / success_response trio) and use it for body-read failures in handle_proxy. The log message content is unchanged — only the severity is downgraded from ERROR to WARN.

Testing

  • unit tests

When Lambda freezes or terminates a function instance, the OS closes the
TCP connection mid-request. The extension's proxy handler fails to buffer
the body and logs at ERROR level, creating noise with no actionable signal.

This is expected Lambda lifecycle behavior — the function completed
successfully and nothing in the extension is broken. Introduce
`warn_response` (mirroring `error_response`) and use it for this path so
the log level correctly reflects an external event rather than an
extension fault.

Fixes #1000
@litianningdatadog litianningdatadog marked this pull request as ready for review February 24, 2026 22:58
@litianningdatadog litianningdatadog requested a review from a team as a code owner February 24, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants