Skip to content

fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
litianningdatadog merged 1 commit into from
Feb 26, 2026
+8 −1
Merged

fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion bottlecap/src/traces/trace_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ impl TraceAgent {
let (parts, body) = match extract_request_body(request).await {
Ok(r) => r,
Err(e) => {
return error_response(
return warn_response(
StatusCode::INTERNAL_SERVER_ERROR,
format!("TRACE_AGENT | handle_proxy | Error extracting request body: {e}"),
);
Expand Down Expand Up @@ -721,6 +721,13 @@ fn error_response<E: std::fmt::Display>(status: StatusCode, error: E) -> Respons
(status, error.to_string()).into_response()
}

/// Like [`error_response`], but logs at WARN level. Use when the failure is caused by an
/// external event (e.g. client disconnected) rather than a bug in the extension itself.
fn warn_response<E: std::fmt::Display>(status: StatusCode, error: E) -> Response {
warn!("{}", error);
(status, error.to_string()).into_response()
}

fn success_response(message: &str) -> Response {
debug!("{}", message);
(StatusCode::OK, json!({"rate_by_service": {}}).to_string()).into_response()
Expand Down
Loading