feat: allow LaunchDarkly project-wide flag prefixes#111
Conversation
5083cf8 to
eee5deb
Compare
eee5deb to
c8860f7
Compare
| flagKeyMapping, | ||
| flagKeyMapping: flagKeyMappingsForReport(), |
There was a problem hiding this comment.
🤖[claude] Suggestion
The SIGINT partial-save handler is missing semverForcedClientKeys and jsonArrayWrappedKeys, both of which are accumulated during the migration. If the user interrupts with Ctrl+C, those fields won't appear in the saved JSON, so an xlsx export from the partial report will show SEMVER-forced and JSON-array-wrapped flags without any warning highlighting.
Consider adding them here to match the success-path shape:
semverForcedClientKeys: semverForcedClientKeys.length > 0 ? semverForcedClientKeys : undefined,
jsonArrayWrappedKeys: jsonArrayWrappedKeys.length > 0 ? jsonArrayWrappedKeys : undefined,
| ), | ||
| ); | ||
| } | ||
| resolvedDdKey = customKey; |
There was a problem hiding this comment.
🤖[claude] Suggestion
After the user confirms a custom key, reservedDatadogKeys is never updated. A later flag in the same migration could pass the classifyDatadogKeyConflict check with the same key (since it's not yet reserved), only for the API creation to fail at runtime with a less clear error.
Consider adding the key to the reserved set immediately after confirmation, matching the pattern at the create path:
resolvedDdKey = customKey;
reservedDatadogKeys.add(customKey); // prevent a later flag from claiming the same key
There was a problem hiding this comment.
Oh good catch. I'll add a follow up PR
Summary
--feature-flag source,targetmappings.