Fix processing pipeline for client-side-stats#8436
Open
andrewlock wants to merge 13 commits intoandrew/client-side-stats/refactor-trace-chunk-modelfrom
Open
Fix processing pipeline for client-side-stats#8436andrewlock wants to merge 13 commits intoandrew/client-side-stats/refactor-trace-chunk-modelfrom
andrewlock wants to merge 13 commits intoandrew/client-side-stats/refactor-trace-chunk-modelfrom
Conversation
andrewlock
added
area:tracer
andrewlock
force-pushed
the
andrew/client-side-stats/update-processing-pipeline
branch
from
0b9d17e to
833ad62
Compare
andrewlock
force-pushed
the
andrew/client-side-stats/refactor-trace-chunk-model
branch
from
d367d99 to
efd496f
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8436) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (74ms) : 69, 79
master - mean (73ms) : 70, 75
section Bailout
This PR (8436) - mean (77ms) : 75, 79
master - mean (79ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8436) - mean (1,080ms) : 1032, 1128
master - mean (1,073ms) : 1025, 1120
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (114ms) : 109, 120
master - mean (113ms) : 108, 119
section Bailout
This PR (8436) - mean (113ms) : 110, 116
master - mean (115ms) : 110, 121
section CallTarget+Inlining+NGEN
This PR (8436) - mean (791ms) : 770, 812
master - mean (785ms) : 763, 806
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (101ms) : 96, 105
master - mean (101ms) : 97, 105
section Bailout
This PR (8436) - mean (103ms) : 99, 108
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8436) - mean (939ms) : 909, 969
master - mean (939ms) : 899, 978
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (101ms) : 96, 106
master - mean (99ms) : 96, 102
section Bailout
This PR (8436) - mean (104ms) : 99, 108
master - mean (103ms) : 98, 108
section CallTarget+Inlining+NGEN
This PR (8436) - mean (821ms) : 790, 852
master - mean (819ms) : 789, 849
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (202ms) : 197, 206
master - mean (202ms) : 197, 207
section Bailout
This PR (8436) - mean (205ms) : 201, 209
master - mean (206ms) : 201, 211
section CallTarget+Inlining+NGEN
This PR (8436) - mean (1,183ms) : 1133, 1233
master - mean (1,193ms) : 1155, 1232
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (287ms) : 280, 295
master - mean (293ms) : 285, 301
section Bailout
This PR (8436) - mean (289ms) : 283, 295
master - mean (294ms) : 289, 299
section CallTarget+Inlining+NGEN
This PR (8436) - mean (962ms) : 938, 985
master - mean (975ms) : 946, 1003
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (282ms) : 276, 289
master - mean (287ms) : 279, 296
section Bailout
This PR (8436) - mean (283ms) : 277, 289
master - mean (287ms) : 279, 294
section CallTarget+Inlining+NGEN
This PR (8436) - mean (1,157ms) : 1112, 1201
master - mean (1,160ms) : 1123, 1197
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8436) - mean (282ms) : 275, 288
master - mean (285ms) : 279, 291
section Bailout
This PR (8436) - mean (283ms) : 277, 288
master - mean (285ms) : 280, 290
section CallTarget+Inlining+NGEN
This PR (8436) - mean (1,043ms) : 1003, 1083
master - mean (1,049ms) : 1009, 1089
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
force-pushed
the
andrew/client-side-stats/update-processing-pipeline
branch
2 times, most recently
from
a99ae1b to
bf1d86f
Compare
BenchmarksBenchmark execution time: 2026-04-16 09:05:38 Comparing candidate commit 1783517 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3179a17d78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andrewlock
force-pushed
the
andrew/client-side-stats/update-processing-pipeline
branch
from
3179a17 to
2a9f4b3
Compare
andrewlock
force-pushed
the
andrew/client-side-stats/refactor-trace-chunk-model
branch
from
efd496f to
bda5853
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a9f4b3577
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Apr 13, 2026
lucaspimentel
approved these changes
Apr 13, 2026
andrewlock
force-pushed
the
andrew/client-side-stats/update-processing-pipeline
branch
from
2a9f4b3 to
2106339
Compare
andrewlock
force-pushed
the
andrew/client-side-stats/refactor-trace-chunk-model
branch
from
bda5853 to
682df90
Compare
zacharycmontoya
approved these changes
Apr 15, 2026
Contributor
zacharycmontoya
left a comment
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM with some small comments!
andrewlock
force-pushed
the
andrew/client-side-stats/update-processing-pipeline
branch
from
2106339 to
1783517
Compare
andrewlock
force-pushed
the
andrew/client-side-stats/refactor-trace-chunk-model
branch
from
682df90 to
bcf6c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates the processing pipeline for client side stats
Reason for change
The bulk of the CSS 1.2.0 work was done in #8420, but the span-processing pipeline wasn't the same as the Go agent:
ProcessTrace)ShouldKeepTrace)AddRange)Implementation details
The difference was mostly due to the way we had separate
ProcessTrace()andShouldKeepTrace()methods. By merging them, we can encapsulate the pipeline, and ensure that we mirror the way the Go agent processes traces.Additionally, there are two different mechanisms for dropping spans now - p0drops and "trace filtering", so added a new metric tag
reason:trace_filterfor it.Additionally, made some small optimizations:
ITraceProcessorwhen it only contains oneTraceFilteralgorithm to correctly look for local trace root, starting from last span_statsAggregatornon-null inAgentWriterto eliminate a bunch of null checksTest coverage
Covered by existing tests.
Other details
Part of a stack:
charhelpers likeIsAsciiHexDigit#8417IpAddressObfuscationUtilfor use with client-side-stats #8418ContainsSpanIdtoSpanCollection#8435