Stop vendoring resx for vendored microsoft code#8461
Stop vendoring resx for vendored microsoft code#8461andrewlock wants to merge 1 commit intoandrew/update-vendors-3from
Conversation
BenchmarksBenchmark execution time: 2026-04-16 14:22:37 Comparing candidate commit ef58938 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8461) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (72ms) : 69, 74
master - mean (71ms) : 69, 73
section Bailout
This PR (8461) - mean (76ms) : 74, 78
master - mean (76ms) : 73, 79
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,059ms) : 1020, 1097
master - mean (1,062ms) : 1019, 1105
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (113ms) : 110, 116
master - mean (112ms) : 109, 116
section Bailout
This PR (8461) - mean (114ms) : 112, 116
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8461) - mean (764ms) : 740, 788
master - mean (784ms) : 761, 807
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (99ms) : 96, 103
master - mean (100ms) : 96, 103
section Bailout
This PR (8461) - mean (101ms) : 98, 104
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8461) - mean (926ms) : 895, 958
master - mean (930ms) : 890, 971
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (99ms) : 96, 102
master - mean (98ms) : 94, 102
section Bailout
This PR (8461) - mean (100ms) : 97, 103
master - mean (99ms) : 96, 103
section CallTarget+Inlining+NGEN
This PR (8461) - mean (814ms) : 775, 853
master - mean (819ms) : 780, 859
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (212ms) : 207, 217
master - mean (206ms) : 201, 211
section Bailout
This PR (8461) - mean (215ms) : 211, 220
master - mean (210ms) : 206, 213
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,233ms) : 1181, 1285
master - mean (1,207ms) : 1169, 1246
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (304ms) : 297, 311
master - mean (297ms) : 289, 305
section Bailout
This PR (8461) - mean (307ms) : 301, 313
master - mean (299ms) : 293, 306
section CallTarget+Inlining+NGEN
This PR (8461) - mean (999ms) : 973, 1026
master - mean (1,002ms) : 964, 1040
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (300ms) : 293, 307
master - mean (292ms) : 286, 297
section Bailout
This PR (8461) - mean (299ms) : 294, 305
master - mean (293ms) : 288, 297
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,182ms) : 1149, 1215
master - mean (1,167ms) : 1124, 1210
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (295ms) : 289, 301
master - mean (289ms) : 283, 296
section Bailout
This PR (8461) - mean (297ms) : 291, 304
master - mean (290ms) : 284, 296
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,073ms) : 991, 1156
master - mean (1,067ms) : 971, 1162
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
7f66c52 to
3b42dd4
Compare
bdf65ae to
ef58938
Compare
Summary of changes
Stop vendoring the
SR+ regex files for microsoft codeReason for change
Using
ResourceManageris overkill, as we don't deploy all the translations etc anyway, and don't want to.Implementation details
Replaced all the
SR.accesses in previous PRs, so this is now dead code that we can remove.Test coverage
If it builds, we're good
Other details
https://datadoghq.atlassian.net/browse/APMLP-1207
Note that currently, there's a lot of
Utf8Formattercode that isn't used, and could be excluded, however, given that theoretically we could/should use this in the future. I'm torn whether to just leave it in, or whether to tear it out for now, and restore it if/when we want to use it later. Any thoughts?Part of a stack updating our vendored system code