Skip to content

Comments

fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372

Open
hannahkm wants to merge 5 commits intomainfrom
hannahkm/go-error-testing
Open

fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372
hannahkm wants to merge 5 commits intomainfrom
hannahkm/go-error-testing

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Feb 24, 2026

Motivation

Changes to error tracking in dd-trace-go v2.7.0 will cause system tests to break in the tracer. See this RFC.

Changes

  • For all other tracers AND dd-trace-go version v2.6.0, check that error.stack exists.
  • For dd-trace-go >= 2.7.0, check that error.handling_stack exists.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
tests/parametric/test_otel_span_methods.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@hannahkm hannahkm changed the title Hannahkm/go error testing fix: error tracking tags were incorrect for go tracer >= 2.7.0 Feb 24, 2026
@hannahkm hannahkm marked this pull request as ready for review February 24, 2026 15:02
@hannahkm hannahkm requested review from a team as code owners February 24, 2026 15:02
@hannahkm hannahkm requested review from BridgeAR and removed request for a team February 24, 2026 15:02
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f74864553a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant