Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manifests/cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ manifest:
tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields: missing_feature # Created by easy win activation script
tests/parametric/test_otel_metrics.py: missing_feature
tests/parametric/test_otel_span_methods.py: irrelevant (library does not implement OpenTelemetry)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_with_baggage.py::Test_Otel_Span_With_Baggage: missing_feature
tests/parametric/test_otel_tracer.py::Test_Otel_Tracer::test_otel_force_flush: irrelevant (library does not implement OpenTelemetry)
tests/parametric/test_otel_tracer.py::Test_Otel_Tracer::test_otel_simple_trace: irrelevant (library does not implement OpenTelemetry)
Expand Down
1 change: 1 addition & 0 deletions manifests/cpp_httpd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ manifest:
tests/integrations/test_otel_drop_in.py: irrelevant (library does not implement OpenTelemetry)
tests/otel/: irrelevant (library does not implement OpenTelemetry)
tests/parametric/: irrelevant (Parametric scenario is not applied on C++ httpd)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationExtraServices: missing_feature
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDD: missing_feature
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDDNoCache: missing_feature
Expand Down
1 change: 1 addition & 0 deletions manifests/cpp_nginx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ manifest:
tests/integrations/test_inferred_proxy.py: missing_feature
tests/integrations/test_otel_drop_in.py::Test_Otel_Drop_In: irrelevant (library does not implement OpenTelemetry)
tests/otel/test_context_propagation.py::Test_Otel_Context_Propagation_Default_Propagator_Api: irrelevant (library does not implement OpenTelemetry)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationExtraServices: missing_feature
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDD: v1.3.0
tests/remote_config/test_remote_configuration.py::Test_RemoteConfigurationUpdateSequenceASMDDNoCache: irrelevant (we opt into cache)
Expand Down
1 change: 1 addition & 0 deletions manifests/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,7 @@ manifest:
tests/parametric/test_otel_metrics.py::Test_Otel_Metrics_Telemetry::test_telemetry_metrics_grpc: missing_feature (OTel metrics telemetry metrics (otel.metrics_export_attempts) not yet fully flushed in time)
tests/parametric/test_otel_metrics.py::Test_Otel_Metrics_Telemetry::test_telemetry_metrics_http_protobuf: missing_feature
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags: missing_feature
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 2.53.0)
component_version: <2.53.0
Expand Down
1 change: 1 addition & 0 deletions manifests/envoy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ manifest:
tests/appsec/test_traces.py: v1.72.0
tests/appsec/test_traces.py::Test_CollectRespondHeaders::test_header_collection: missing_feature (The endpoint /headers is not implemented in the weblog)
tests/appsec/test_versions.py::Test_Events: v1.72.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/test_config_consistency.py::Test_Config_UnifiedServiceTagging_CustomService: v1.72.0
tests/test_scrubbing.py: v1.72.0
tests/test_semantic_conventions.py: v1.72.0
Expand Down
3 changes: 3 additions & 0 deletions manifests/golang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1035,6 +1035,9 @@ manifest:
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags: # Modified by easy win activation script
- declaration: missing_feature (Not implemented)
component_version: <2.5.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go:
- declaration: missing_feature (Not implemented)
component_version: <2.7.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 1.65.0)
component_version: <1.65.0
Expand Down
1 change: 1 addition & 0 deletions manifests/haproxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ manifest:
tests/appsec/test_traces.py: v2.4.0
tests/appsec/test_traces.py::Test_CollectRespondHeaders::test_header_collection: missing_feature (The endpoint /headers is not implemented in the weblog)
tests/appsec/test_versions.py::Test_Events: v2.4.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/test_config_consistency.py::Test_Config_UnifiedServiceTagging_CustomService: v2.4.0
tests/test_scrubbing.py: v2.4.0
tests/test_semantic_conventions.py: v2.4.0
Expand Down
1 change: 1 addition & 0 deletions manifests/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3384,6 +3384,7 @@ manifest:
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags:
- declaration: missing_feature (Not implemented)
component_version: <1.40.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 1.35.0)
component_version: <1.35.0
Expand Down
1 change: 1 addition & 0 deletions manifests/java_otel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ manifest:
tests/integrations/test_open_telemetry.py::Test_MySql::test_properties: bug (OTEL-2778)
tests/integrations/test_open_telemetry.py::Test_Postgres::test_obfuscate_query: bug (OTEL-2778)
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_obfuscate_query: bug (OTEL-2778)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
1 change: 1 addition & 0 deletions manifests/k8s_cluster_agent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ manifest:
tests/k8s_lib_injection/test_k8s_lib_injection_profiling.py::TestK8sLibInjectioProfilingClusterEnabled: v7.57.0
tests/k8s_lib_injection/test_k8s_lib_injection_profiling.py::TestK8sLibInjectioProfilingClusterOverride: v7.57.0
tests/k8s_lib_injection/test_k8s_lib_injection_profiling.py::TestK8sLibInjectioProfilingDisabledByDefault: v7.57.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
1 change: 1 addition & 0 deletions manifests/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1862,6 +1862,7 @@ manifest:
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags:
- declaration: missing_feature (Implemented in v5.17.0 & v4.41.0)
component_version: <5.17.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 5.16.0)
component_version: <5.16.0
Expand Down
1 change: 1 addition & 0 deletions manifests/nodejs_otel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ manifest:
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_error_exception_event: missing_feature (Open telemetry with nodejs is not generating this information.)
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_error_type_and_stack: missing_feature (Open telemetry with nodejs is not generating this information.)
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_obfuscate_query: bug (OTEL-940)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
1 change: 1 addition & 0 deletions manifests/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ manifest:
- declaration: missing_feature (Not implemented)
component_version: <1.3.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags: "missing_feature (\"Not supported: DD only sets error.stack to not break tracer semantics\")"
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 1.1.0)
component_version: <1.1.0
Expand Down
1 change: 1 addition & 0 deletions manifests/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1562,6 +1562,7 @@ manifest:
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags:
- declaration: missing_feature (Not implemented)
component_version: <2.9.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 2.9.0)
component_version: <2.9.0
Expand Down
1 change: 1 addition & 0 deletions manifests/python_lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ manifest:
- weblog_declaration:
"*": v8.113.0
alb-multi: v8.114.0.dev
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/test_resource_renaming.py: missing_feature
tests/test_rum_injection.py: irrelevant (RUM injection only supported for Java)
tests/test_v1_payloads.py: missing_feature
1 change: 1 addition & 0 deletions manifests/python_otel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ manifest:
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_db_connection_string: "missing_feature (Open telemetry doesn't send this span for python)"
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_db_operation: "missing_feature (Open Telemetry doesn't send this span for python but it should do)"
tests/integrations/test_open_telemetry.py::_BaseOtelDbIntegrationTestClass::test_obfuscate_query: bug (OTEL-940)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
1 change: 1 addition & 0 deletions manifests/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1333,6 +1333,7 @@ manifest:
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_all_error_tracking_tags:
- declaration: missing_feature (Not implemented)
component_version: <2.3.0
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attribute_remapping_httpresponsestatuscode:
- declaration: missing_feature (Implemented in 2.0.0)
component_version: <2.0.0
Expand Down
1 change: 1 addition & 0 deletions manifests/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ manifest:
tests/parametric/test_otel_metrics.py::Test_Otel_Metrics_Telemetry::test_telemetry_metrics_http_protobuf: '>=0.2.1' # Modified by easy win activation script
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods: v0.0.1
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_get_span_context: missing_feature (APMSP-2059)
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_record_exception_sets_handling_stack_in_go: irrelevant
tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_set_attributes_different_types_legacy: missing_feature (Old array encoding not supported)
? tests/parametric/test_otel_span_methods.py::Test_Otel_Span_Methods::test_otel_span_extended_reserved_attributes_overrides_analytics_event
: missing_feature (Not implemented)
Expand Down
20 changes: 20 additions & 0 deletions tests/parametric/test_otel_span_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,26 @@ def test_otel_record_exception_sets_all_error_tracking_tags(
assert "error.message" in root_span["meta"]
assert "error.type" in root_span["meta"]

def test_otel_record_exception_sets_handling_stack_in_go(self, test_agent: TestAgentAPI, test_library: APMLibrary):
"""For dd-trace-go > v2.5.0, we set the throw stack (if available) in error.details and the handling stack in error.stack (always)
For dd-trace-go >= v2.7.0, we set the throw stack (if available) in error.stack and the handling stack in error.handling_stack (always)
https://github.com/DataDog/dd-trace-go/pull/4322
"""
with test_library, test_library.otel_start_span("operation") as span:
span.set_status(StatusCode.ERROR, "error_desc")
span.record_exception(
message="woof1", attributes={"string_val": "value", "exception.stacktrace": "stacktrace1"}
)

traces = test_agent.wait_for_num_traces(1)
trace = find_trace(traces, span.trace_id)
root_span = find_span(trace, span.span_id)

assert root_span["error"] == 1
assert "error.handling_stack" in root_span["meta"]
assert "error.message" in root_span["meta"]
assert "error.type" in root_span["meta"]


def run_operation_name_test(
expected_operation_name: str, span_kind: int, attributes: dict, test_library: APMLibrary, test_agent: TestAgentAPI
Expand Down
Loading