Fix schema validation failure in new CSS obfuscation scenarios#7134
Conversation
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68d6e34ef1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| scenarios.trace_stats_computation_obfuscation_disabled, | ||
| scenarios.trace_stats_computation_future_obfuscation_version, | ||
| scenarios.trace_stats_computation_missing_obfuscation_version, | ||
| scenarios.trace_stats_computation_obfuscation_version_zero, |
There was a problem hiding this comment.
Narrow the stats schema exemption to APMSP-2158 paths
For these newly added scenarios, this SchemaBug still has data_path=None, and tests/schemas/utils/schemas_validators.py:27 documents that None treats every data path as a known bug; assert_no_schema_error therefore drops every /v0.6/stats schema violation for the listed libraries in these CSS obfuscation scenarios. Since APMSP-2158 is only the known missing stats fields, unrelated regressions in the stats payload shape for these scenarios will now pass silently; please add path-specific exemptions instead of putting the scenarios under the endpoint-wide exemption.
Useful? React with 👍 / 👎.
Motivation
The dd-trace-js (and python, ruby, etc.) scheduled System Tests started failing on 2026-06-13 with Test_DdtraceSchemas::test_library schema errors on /v0.6/stats payloads:
This is the already-known, accepted gap APMSP-2158: several tracers don't emit the top-level Service field nor the per-stat IsTraceRoot field in their /v0.6/stats payloads. That gap is whitelisted in tests/schemas/test_schemas.py via a SchemaBug exclusion — but only for the appsec_blocking, trace_stats_computation, and tracing_config_nondefault_3 scenarios.
PR #6648 ("Add css obfuscation test APMSP-2764") introduced four new end-to-end scenarios that also generate /v0.6/stats payloads but were not added to the APMSP-2158 whitelist, so the previously-suppressed schema errors now fail across all affected tracers and weblogs.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present