-
Notifications
You must be signed in to change notification settings - Fork 15
Fix schema validation failure in new CSS obfuscation scenarios #7134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robertomonteromiguel
merged 1 commit into
main
from
robertomonteromiguel/fix_schema_validation
Jun 15, 2026
+4
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these newly added scenarios, this
SchemaBugstill hasdata_path=None, andtests/schemas/utils/schemas_validators.py:27documents thatNonetreats every data path as a known bug;assert_no_schema_errortherefore drops every/v0.6/statsschema violation for the listed libraries in these CSS obfuscation scenarios. Since APMSP-2158 is only the known missing stats fields, unrelated regressions in the stats payload shape for these scenarios will now pass silently; please add path-specific exemptions instead of putting the scenarios under the endpoint-wide exemption.Useful? React with 👍 / 👎.