Open
Conversation
nbrownus
force-pushed
the
config-migration
branch
8 times, most recently
from
74ad16c to
040cce2
Compare
nbrownus
changed the title
nbrownus
force-pushed
the
config-migration
branch
from
040cce2 to
e2e3c69
Compare
This was referenced Feb 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firewall config change was getting large so I decided to split the model updates from the UI.
This PR adds a site migration that establishes the default allow-all outbound firewall rule in the site config json or if the site was managed, hydrates the config json with firewall rules from the yaml config.
It also adds support for importing firewall rules from a yaml config file and some integration tests that I've only been able to get running locally for the moment.
A follow on PR will add the UI