Support non-UTC timezones for metrics operations#6344
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | -2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
nscuro
added
backport/5.0.1
defect
Historically we implicitly assumed UTC (and configured our container images explicitly that way). But it turns out users want to customize the timezone used by the application, which makes the implicit assumptions fall apart, in particular WRT metrics and their partition maintenance. This change makes the UTC-ness of metrics operations explicit, which allows the application to be set to arbitrary timezones and still function as intended. Also addresses other code locations that implicitly relied on UTC and made that expectation explicit. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supports non-UTC timezones for metrics operations.
Historically we implicitly assumed UTC (and configured our container images explicitly that way). But it turns out users want to customize the timezone used by the application, which makes the implicit assumptions fall apart, in particular WRT metrics and their partition maintenance.
This change makes the UTC-ness of metrics operations explicit, which allows the application to be set to arbitrary timezones and still function as intended.
Also addresses other code locations that implicitly relied on UTC and made that expectation explicit.
Addressed Issue
Closes #6341
Additional Details
Docs PR: DependencyTrack/docs#152
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/