Fix persistence of ForceInversion checkbox user choices#5122
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoJul 16, 2026
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 16, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/checkbox-forceinversion-persistence
branch
July 16, 2026 20:57
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the
ForceInversionproperty and the checked state are managed in theCheckboxCardcontrol. The main improvements ensure that the checked state is always correctly updated when either the setting name or the inversion flag changes, which addresses issues with property assignment order in XAML.Improvements to property handling and state synchronization:
ForceInversionproperty to a full property with a backing field and setter logic that callsRefreshCheckedFromSetting()to ensure the checked state is recalculated whenForceInversionchanges.RefreshCheckedFromSetting()method, which is now called wheneverSettingNameorForceInversionis set, ensuring correct state even if properties are assigned in any order.ForceInversionand updated event handler management to avoid duplicate event subscriptions.