Skip to content

Add experiment class#57

Merged
DominicOram merged 20 commits into
mainfrom
56_add_experiment_types
Jun 30, 2026
Merged

Add experiment class#57
DominicOram merged 20 commits into
mainfrom
56_add_experiment_types

Conversation

@jacob720

@jacob720 jacob720 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #56
Fixes #51

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.60%. Comparing base (3bb7cd4) to head (90acf75).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   98.56%   98.60%   +0.04%     
==========================================
  Files          17       17              
  Lines         765      787      +22     
==========================================
+ Hits          754      776      +22     
  Misses         11       11              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 requested a review from DominicOram June 25, 2026 16:54
@jacob720 jacob720 force-pushed the 56_add_experiment_types branch from a89fb88 to 956fff6 Compare June 26, 2026 13:38

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Couple of small things:

  • Only part of #56? Does it not fix all of it?
  • Would be good to have some more docs from a caller's perspective on TaskRequest vs. Experiment , what they are, when you would use them etc.

@jacob720

Copy link
Copy Markdown
Collaborator Author

#56 also talks about adding i15-1-specific types for each type of experiment. This needs a bit more thinking as we probably don't want to have types that look like my-15-1-experiment | my-b21-experiment etc, maybe some way to configure what type to expect and validate against it.

Think this should probably be a separate PR so will also make a separate issue for it and can close #56.

@jacob720

Copy link
Copy Markdown
Collaborator Author

#68

@jacob720 jacob720 requested a review from DominicOram June 30, 2026 17:16

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@DominicOram DominicOram merged commit a431dee into main Jun 30, 2026
11 checks passed
@DominicOram DominicOram deleted the 56_add_experiment_types branch June 30, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add experiment types Remove the need for a plan name

2 participants