Explicitly finalise source to cleanup hdf5 file backing dataset store#706
Merged
yousefmoazzam merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
An explicit call to the `finalize()` method of the dataset source has been added in two places: - in the method setting up the source and sink for any section that is not the last section (to delete the temporary hdf5 file used as input to the previous section, which has been superceded by the temporary hdf5 file created as output of the previous section) - after the last section has been completed (for the same reason as above, to delete the temporary hdf5 file used as input to the last section, but must be done independently of `_setup_source_sink()` as that method is not called after the last section has completed, so the code added to it won't help with cleanup of the last section's source) Note that, ideally, the use of `weakref.finalize()` in `DataSetStoreReader` would automatically cleanup the temporary hdf5 files when reader objects are garbage collected, and that explicit calls to `finalize()` would not be necessary. However, because the file-cleanup logic in the reader's `finalize()` method appears to not be getting triggered as expected, it would appear that garbage collection of reader objects is maybe not happening for some reason. This will require further investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IMGDA-192
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes