Skip to content

Explicitly finalise source to cleanup hdf5 file backing dataset store #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yousefmoazzam merged 1 commit into from
Apr 7, 2026
+4 −1
Merged

Explicitly finalise source to cleanup hdf5 file backing dataset store #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion httomo/runner/task_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def execute(self) -> None:
for i, section in enumerate(self._sections):
self._execute_section(section, i)
gpumem_cleanup()
self.source.finalize()

self._log_pipeline(f"Pipeline finished. Took {t.elapsed:.3f}s")
if self.monitor is not None:
Expand Down Expand Up @@ -228,9 +229,11 @@ def _setup_source_sink(self, section: Section, idx: int):
# we have a store-based sink from the last section - use that to determine
# the source for this one
assert isinstance(self.sink, ReadableDataSetSink)
self.source = self.sink.make_reader(
new_source = self.sink.make_reader(
slicing_dim_section, determine_section_padding(section)
)
self.source.finalize()
self.source = new_source

store_backing = determine_store_backing(
comm=self.comm,
Expand Down
Loading