feat: add tests for DiamondDSTheme & update theme to pass tests#252
Open
VictoriaBeilsten-Edmands wants to merge 5 commits into
Open
feat: add tests for DiamondDSTheme & update theme to pass tests#252VictoriaBeilsten-Edmands wants to merge 5 commits into
VictoriaBeilsten-Edmands wants to merge 5 commits into
Conversation
VictoriaBeilsten-Edmands
requested review from
NKatti2011,
douglaswinter and
zoharma
zoharma
previously approved these changes
Jul 7, 2026
Contributor
|
@VictoriaBeilsten-Edmands et al, added a fix to switch the channel token to the more semantic representation |
zoharma
force-pushed
the
vbe/test-theme
branch
6 times, most recently
from
4a1fff9 to
f8fc708
Compare
- Fix token names to be semantic - Fix pure grey for a cooler oner - Fix avatar issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds tests for the the DiamondDSTheme and checks tokens, mappings and overrides.
Updates tokens to pass tests to synchronise channel and hex values & remove border-subtle refs.
Add onSolid to TypeTextOptions.