fix(cli): don't hang on stdin for destructive ops in non-interactive sessions#463
Open
PeterGuy326 wants to merge 1 commit into
Open
Conversation
…tructive ops in non-interactive sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Destructive compat commands (e.g.
calendar room delete,calendar participant delete) unconditionally read a yes/no confirmation from stdin when--yesis not passed. In a non-interactive session (pipe / CI / test harness / AI agent), stdin hits EOF immediately, so the command:Operation cancelledto stderrThe destructive operation silently does not run, yet reports success. Any
-f jsoncaller parsing the empty stdout treats it as a failure. This is the root cause of thecalendarfailures in the cli_to_mcp evaluation.Reproduce (before)
Fix
Before falling into the interactive prompt, detect a non-interactive stdin (
os.Stdinis not a character device) and return a structured validation error instructing the caller to pass--yes, instead of hanging on / EOF-ing the prompt.After
Interactive TTY sessions are unaffected — they still get the confirmation prompt.