Skip to content

fix(cli): don't hang on stdin for destructive ops in non-interactive sessions #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterGuy326 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): don't hang on stdin for destructive ops in non-interactive sessions #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/compat/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,16 @@ func NewDirectCommand(route Route, runner executor.Runner) *cobra.Command {
}
}
if blocked, _ := params["_blocked"].(bool); blocked {
// Non-interactive stdin (pipe / CI / test harness / AI agent):
// we cannot read a confirmation. Previously the prompt below hit
// EOF immediately, printed "Operation cancelled" to stderr, left
// stdout empty and returned nil with exit 0 — silently no-op'ing
// the destructive command while reporting success, and breaking
// any -f json caller that parses the empty stdout as a failure.
// Refuse with a structured error telling the caller to pass --yes.
if fi, err := os.Stdin.Stat(); err != nil || (fi.Mode()&os.ModeCharDevice) == 0 {
return apperrors.NewValidation("this is a destructive operation; re-run with --yes to confirm (cannot prompt for confirmation in a non-interactive session)")
}
// Interactive confirmation for destructive operations (consistent with Helper commands)
fmt.Fprintln(cmd.ErrOrStderr(), "⚠️ This is a destructive operation.")
fmt.Fprint(cmd.ErrOrStderr(), "Confirm? (yes/no): ")
Expand Down
Loading