Conversation
Add RDFS.label to IGNORED_NODE_SHAPE_PREDICATES so that shape labels (ending in " shape") no longer overwrite OWL class labels in the generated specification. Also remove a stale merge conflict marker in main.py. Resolves: DPROD-18, #79 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jgeluk
requested review from
FroehlichMarcel,
andrea-gioia,
joshcornejo,
nvar,
rivettp and
tonyseale
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges DPROD-18 into ballot/4.
Issue: #79 — Use of "shape" in rdfs:label of shapes makes its way into spec
Changes:
spec-generator/globals.py: ignore shape-related predicates so SHACL labels don't leakspec-generator/main.py: align with globalsPart of ballot/4 consolidation (DPROD-16, DPROD-17, DPROD-18, DPROD-20, joshcornejo-patch-2 → ballot/4).
Made with Cursor