Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's data ingestion capabilities by enabling the direct loading of NetCDF files from server-side paths. It streamlines the process of handling NetCDF data by consolidating the loading mechanism into a dedicated utility, making the application more versatile in how it accesses and processes scientific datasets. The changes also include updates to the global state to better manage the visibility of variable selection components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to load NetCDF files from a server-side path, which is a great addition. The code is well-structured, especially with the extraction of loadNetCDF into a utility function and centralizing the openVariables state in the global store.
My review includes a few suggestions to improve error handling and robustness, which are critical for asynchronous operations like file fetching and parsing. Specifically, I've pointed out a couple of places where unhandled promise rejections could occur and suggested using try...catch blocks. I've also included some minor improvements for code clarity and performance.
TheJeran
left a comment
There was a problem hiding this comment.
With the new variables globals, I find the logic easier to just load them directly in components without having to trace what is being passed where.
|
let's do follow-up PR for cleanup. There are several places where this needs to be taken care of, with care. |
|
I have been thinking about rules and practices over the last few days for implementing across the entire code base. So this can be something that gets taken care of then |
TheJeran
left a comment
There was a problem hiding this comment.
Global variables are now imported instead of passed
… into la/nc_reads
… into la/nc_reads
… into la/nc_reads
|
omg why is it so difficult to just undo last commit |
|
Changes were pushed with #603 |
This PR keeps current functionality to load netcdf
but more importantly it adds a path to load
ncfiles when provided from a server.With this changes now the following are possible in the command line
[new]
@TheJeran please comment on
src/utils/loadNetCDF.tscurrent location and name.