La/nc reads rev

[TheJeran]

This is
#600
But reverted to before I started coding. I realized the reason the variables were passed into it is because it uses local states to control the view

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application's state management and file loading mechanisms, particularly for NetCDF data. By centralizing the logic for loading NetCDF files into a dedicated utility and moving the openVariables state to a global store, the changes significantly streamline component interactions and improve the maintainability and robustness of local file handling. This leads to cleaner component code and a more consistent user experience when dealing with dataset variables.

Highlights

• Centralized NetCDF Loading Logic: Extracted the core logic for loading NetCDF files into a new utility function (loadNetCDF.ts), making it reusable and simplifying components that handle file uploads.
• Global State Management for Variable Visibility: Migrated the openVariables state, which controls the visibility of the variables panel, from local component state to the global Zustand store. This eliminates prop drilling and centralizes control.
• Simplified Component Interfaces: Refactored Dataset, Variables, LocalNetCDF, LocalZarr, and MetaDataInfo components to consume openVariables and its setter directly from the global store, reducing prop complexity.
• Enhanced Local NetCDF File Handling: Improved the LandingHome component's useEffect hook to specifically handle local: prefixed stores, enabling direct fetching and loading of NetCDF files via the new utility function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors state management by moving the openVariables state into the global Zustand store, which is a good improvement for code clarity and maintainability. It also extracts the NetCDF file loading logic into a reusable utility function. I've found a potential race condition in the new logic for handling local: stores in LandingHome.tsx where an asynchronous function is not awaited and there's no cleanup for the async operation in the useEffect hook.

[gemini-code-assist]

The loadNetCDF function is asynchronous, but it's not being awaited here. This means useGlobalStore.setState({openVariables: true}) will execute immediately, potentially before loadNetCDF has finished its async operations and updated the necessary state. This can lead to race conditions and an inconsistent UI state.

Additionally, this useEffect hook initiates an asynchronous fetch operation but lacks a cleanup mechanism. If the initStore prop changes while a fetch is in progress, a new fetch will start, but the old one might still complete and update the state, leading to further race conditions. A cleanup function should be implemented to handle this, for example using a mounted flag as seen in another useEffect in this file.

        .then(async (blob) => {
          await loadNetCDF(blob, filename);
          useGlobalStore.setState({openVariables: true});
        })