Merged
Conversation
swansontec
approved these changes
Feb 26, 2026
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
Two small changes requested, but otherwise this seems reasonable.
|
|
||
| type Config = ReturnType<typeof asConfig> | ||
|
|
||
| function makeMockDb( |
Contributor
There was a problem hiding this comment.
Can the return value be DocumentScope<unknown>, and then put the return {} as any hack inside? That would make it clearer what this is supposed to mock.
test/couchdb/synced-document.test.ts
Outdated
| type Config = ReturnType<typeof asConfig> | ||
|
|
||
| function makeMockDb( | ||
| store: { [id: string]: { _rev: string; [key: string]: unknown } } = {} |
Contributor
There was a problem hiding this comment.
Can this be Record<string, { ... }>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Changes
syncedDocument’s behavior when a document fails to clean by adding configurable fallback strategies and a failure callback; this can affect how corrupted data is handled and persisted during sync.Overview
Adds optional
SyncedDocumentOptionstosyncedDocument, letting callers choose how to handle cleaner failures viacleanFailStrategy(resetto defaults orpreservelast known-good value) and anonCleanFailnotification callback.Refactors sync cleaning to catch cleaner exceptions explicitly (instead of using
asMaybe), and adds a comprehensive test suite covering creation/repair behavior, change events, and the new failure-handling modes; includes a CHANGELOG entry documenting the new options.Written by Cursor Bugbot for commit 420dfbd. This will update automatically on new commits. Configure here.