fix: suppress duplicate banner on settled/paid reports by Krishna2323 · Pull Request #89472 · Expensify/App

Krishna2323 · 2026-05-04T08:22:12Z

Explanation of Change

Fixed Issues

$ #88305
PROPOSAL:

Tests

Prerequisites

Account with at least one workspace

Steps to verify fix

Launch app
Open workspace chat
Create 2 manual expenses (same amount to trigger duplicate detection)
Open the expense report
Submit, approve and pay the expense report
Open either paid expense
Verify the "Potential duplicate" message does not appear in the header
Navigate back to the paid expense report
Verify the "Potential duplicate" status bar does not appear on the report

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-05-04T08:26:55Z

@codex review

codecov · 2026-05-04T08:30:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestHeader.tsx	`0.00% <0.00%> (ø)`
src/hooks/useMoneyReportHeaderStatusBar.ts	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

chatgpt-codex-connector · 2026-05-04T08:30:12Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-05-04T08:47:15Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2026-05-04T12:37:01Z

types are failing

Krishna2323 · 2026-05-13T12:53:38Z

@situchan bump

Krishna2323 · 2026-05-18T19:10:13Z

@situchan could you please review this today?

situchan · 2026-05-18T19:11:20Z

yes sorry this was out of my radar

situchan · 2026-05-18T20:54:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

situchan · 2026-05-18T22:02:37Z

Shouldn't this be fixed in backend? This doesn't happen optimistically. I feel like just hiding violations in frontend is workaround.
CreateDistanceRequest api is sending violations in Onyx data.
After opening report, OpenReport sends violations set to null in Onyx data.

situchan

Approving in case we go with frontend solution.
But the root cause is in backend

JS00001 · 2026-05-20T18:55:16Z

Yeah I agree this could be fixed better on the BE, let me take a look

JS00001 · 2026-05-27T14:16:12Z

Looked through this, lets keep this FE change. I dont think we should update the BE for this case

OSBotify · 2026-05-27T14:26:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-27T15:23:13Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-27T15:32:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89472.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0b21f63a88a-4205783-e3da9a99b9a526bb1b45607ea67788b5dffb07ee/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0b21f63-4205783-f18fc8f5219db102fdc71b0636a56440bd86196a/index.html

Web 🕸️
https://89472.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-27T17:56:46Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.84-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-27T18:02:23Z

Yes, help site changes are needed. This PR suppresses the Potential duplicate banner on settled/paid reports, but two help site articles don't explicitly mention this behavior.

I've created a draft PR with the updates: #91868

Changes made:

How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md — Added clarification that the Potential duplicate label does not appear on settled or paid reports (in the "Who Can Use" section)
Why-Expenses-Duplicate.md — Updated the FAQ answer for "Will Expensify warn me about duplicate expenses?" to note the warning does not appear on settled or paid reports

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T10:49:51Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T10:52:30Z

I reviewed the changes in this PR and the existing help site articles under App/docs/articles.

No help site changes are required.

This PR is a bug fix that suppresses the "Potential duplicate" banner on settled/paid reports. The existing help site documentation already describes the correct (post-fix) behavior:

How to Find and Resolve Flagged Duplicate Expenses already scopes duplicate resolution to "Draft and Outstanding reports"
Why Expenses Duplicate does not reference duplicates on settled reports

Since the docs already match the intended behavior, no updates are needed.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T13:47:03Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.88-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T13:50:37Z

I reviewed the changes in this PR and confirmed that help site updates are needed. This PR suppresses the Potential duplicate banner on settled/paid reports, and the help site articles don't currently mention this behavior.

I've created a draft PR with the required docs updates: #91970

Changes made:

How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md — Added a note under "Who can use duplicate detection" clarifying that duplicate warnings are not displayed on Paid/settled reports. Added a new FAQ entry "Will duplicate warnings appear on Paid reports?"
Why-Expenses-Duplicate.md — Added a note to the "Will Expensify warn me about duplicate expenses?" FAQ clarifying the Paid/settled report behavior.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

fix: suppress duplicate banner on settled/paid reports

ce588ab

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 May 4, 2026

Krishna2323 marked this pull request as ready for review May 4, 2026 08:47

Krishna2323 requested review from a team as code owners May 4, 2026 08:47

melvin-bot Bot requested review from heyjennahay and situchan May 4, 2026 08:47

melvin-bot Bot removed request for a team May 4, 2026 08:47

Krishna2323 mentioned this pull request May 4, 2026

Expense - Potential duplicate message is shown in header for paid expense briefly #88305

Open

7 tasks

JS00001 approved these changes May 4, 2026

View reviewed changes

Krishna2323 added 2 commits May 4, 2026 18:58

Merge branch 'Expensify:main' into krishna2323/issue/88305

6cbef2e

Merge branch 'Expensify:main' into krishna2323/issue/88305

9c4a0cb

Krishna2323 added 2 commits May 17, 2026 01:46

Merge branch 'Expensify:main' into krishna2323/issue/88305

46f9b70

Merge branch 'Expensify:main' into krishna2323/issue/88305

42d174e

JS00001 approved these changes May 18, 2026

View reviewed changes

situchan approved these changes May 18, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 May 18, 2026 22:05

JS00001 merged commit 0b21f63 into Expensify:main May 27, 2026
37 of 38 checks passed

OSBotify mentioned this pull request May 27, 2026

Deploy Checklist: New Expensify 2026-05-27 #91866

Open

75 tasks

MelvinBot mentioned this pull request May 27, 2026

[Payment due @Krishna2323] [No QA] Docs updates for E/A#89472 Clarify duplicate warning hidden on settled reports #91868

Draft

MelvinBot mentioned this pull request May 28, 2026

[No QA] Docs updates for E/A#89472 Suppress duplicate banner on settled paid reports #91970

Draft

Conversation

Krishna2323 commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Prerequisites

Steps to verify fix

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented May 4, 2026

Uh oh!

codecov Bot commented May 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

melvin-bot Bot commented May 4, 2026

Uh oh!

JS00001 commented May 4, 2026

Uh oh!

Krishna2323 commented May 13, 2026

Uh oh!

Krishna2323 commented May 18, 2026

Uh oh!

situchan commented May 18, 2026

Uh oh!

situchan commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented May 18, 2026

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented May 20, 2026

Uh oh!

JS00001 commented May 27, 2026

Uh oh!

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented May 4, 2026 •

edited

Loading

codecov Bot commented May 4, 2026 •

edited by github-actions Bot

Loading

situchan commented May 18, 2026 •

edited

Loading