fix(cli): enable keyring cli feature to restore use_native_store on keyring 4.1#164
Closed
BryanFRD wants to merge 1 commit into
Closed
fix(cli): enable keyring cli feature to restore use_native_store on keyring 4.1#164BryanFRD wants to merge 1 commit into
BryanFRD wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by the lean keyring-core + platform-store version (no SQLite/clap bloat). See follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163.
CI (Rust CLI)has been red onmainsince the keyring 4.1.0/4.1.1 bumps (#159/#160):cargo clippyfails witherror[E0425]: cannot find function use_native_store in crate keyringatcli/src/storage.rs:14.Cause: keyring 4.1 split into
default = ["v1"]and aclifeature, movinguse_native_storeinto theclimodule. We depend onkeyring = "4"(default features) so it is no longer at the crate root.Fix:
keyring = { version = "4", default-features = false, features = ["cli"] }. Thecliuse_native_store(prefer_secret_service: bool)is behavior-identical to before (true= Secret Service on Linux), socli/src/storage.rsis unchanged.Verified locally:
cargo check,cargo clippy --all-targets -- -D warnings, andcargo fmt --checkall pass (Windows target). CI covers Linux.Note / follow-up: the
clifeature pulls a lot of transitive deps the CLI does not need (clap, rpassword, anddb-keystore→ a SQLite engine). The keyring maintainers explicitly recommend that real apps linkkeyring-core+ only the platform store crates they need instead. A lean follow-up can dropkeyringentirely and callkeyring_core::set_default_store(<platform>::Store::new())under#[cfg(target_os)]— happy to do that as a separate PR.