Conversation
Add data-surface-variant aliases and standalone surface-level defaults for bridge-generated and runtime-assigned markup. Update docs, demo coverage, release notes, and package metadata for the 1.3.0 API contract.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Interactive Surface CSS to support runtime-assigned “surface intent” via data attributes, adds standalone depth defaults for data-surface-level, and refreshes docs/demo/release metadata for the 1.3.0 contract.
Changes:
- Add
data-surface-variant="…"selectors as aliases for existing.variant-*classes. - Add per-level defaults for
data-surface-level="1|2|3"(depth + state-layer opacity hooks) and expand Playwright coverage. - Update docs/demo/release notes and bump package version to
1.3.0.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| wiki/Token-Reference.md | Documents UI Style Kit 2.x bridge expectations and new per-level token hooks. |
| wiki/Testing-and-Quality.md | Updates stated Playwright coverage to include data-hook parity and level defaults. |
| wiki/Installation-and-Usage.md | Adds data-attribute usage examples and clarifies bridge + standalone hook behavior. |
| wiki/Home.md | Updates displayed current version/tag to 1.3.0 and adds data-hook example. |
| wiki/Getting-Started.md | Adds runtime-assigned surface intent example using data attributes. |
| wiki/API-Reference.md | Documents data attribute API for variants and introduces surface level documentation. |
| tests/interactive-surface.spec.ts | Adds tests for data-variant parity and surface-level default depth/state values. |
| tests/example.spec.ts | Adds test ensuring token editor modal semantics exist only while open. |
| README.md | Adds data attribute API docs and ecosystem integration section; updates release checklist example tag. |
| package.json | Bumps package version to 1.3.0. |
| package-lock.json | Updates lockfile package version entries to 1.3.0. |
| interactive-surface.css | Implements data-surface-variant aliases and adds standalone per-level defaults for data-surface-level. |
| index.html | Updates demo markup to use data hooks, refines token editor modal semantics, and refreshes embedded docs snippets. |
| docs/superpowers/specs/2026-07-08-interactive-surface-data-hooks.md | Adds a spec/follow-up doc describing the new public hooks and verification targets. |
| CHANGELOG.md | Adds 1.3.0 release notes for the new data hooks, level defaults, and coverage/docs updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- CSS: Level-1/2/3 rules now set internal --_is-* vars with public bridge tokens as first fallback instead of writing to public tokens, preserving import-order independence - Test: Resolve state-layer opacity values via a probe element's opacity property rather than reading raw custom-property token streams - index.html: Replace @latest with @<version> placeholder in embedded CDN code block for reproducibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add data-surface-variant aliases and standalone surface-level defaults for bridge-generated and runtime-assigned markup.
Update docs, demo coverage, release notes, and package metadata for the 1.3.0 API contract.
Summary
Describe the change and why it is needed.
Scope
Validation
List commands you ran and results.
npm run lint:css npm run test:install npm test npm run pack:dryAPI and Behavior Impact
Documentation
Notes
Anything reviewers should focus on.