-
Notifications
You must be signed in to change notification settings - Fork 0
Add Interactive Surface data hook support #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
docs/superpowers/specs/2026-07-08-interactive-surface-data-hooks.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Interactive Surface Data Hooks Follow-Up | ||
|
|
||
| ## Summary | ||
|
|
||
| This follow-up implements the `interactive-surface-css` portion of the three-library ecosystem plan. The package remains an interaction primitive, while adding data-attribute hooks that can be assigned by apps, renderers, or companion CSS libraries without requiring style-specific class names. | ||
|
|
||
| ## Public API | ||
|
|
||
| - Existing class variants remain supported: | ||
| - `.variant-primary` | ||
| - `.variant-secondary` | ||
| - `.variant-accent` | ||
| - `.variant-subtle` | ||
| - `.variant-warning` | ||
| - `.variant-danger` | ||
| - New equivalent data variant hook: | ||
| - `data-surface-variant="primary|secondary|accent|subtle|warning|danger"` | ||
| - Existing `data-surface-level` support now has standalone defaults for: | ||
| - `data-surface-level="1"` | ||
| - `data-surface-level="2"` | ||
| - `data-surface-level="3"` | ||
|
|
||
| ## Ownership Boundaries | ||
|
|
||
| - `layout-style-css` owns structure and layout recipes. | ||
| - `ui-style-kit-css` owns visual theme identity, color roles, and style systems. | ||
| - `interactive-surface-css` owns hover, focus, active, selected, pressed, disabled, reduced-motion, and forced-colors behavior on `.interactive-surface`. | ||
|
|
||
| Interactive Surface does not define global theme tokens and does not depend on either companion package. | ||
|
|
||
| ## Verification Targets | ||
|
|
||
| - Data variant styles match the existing class variant styles. | ||
| - Surface levels have distinct standalone depth defaults. | ||
| - UI Style Kit bridge imports can continue to provide stronger token values through the public `--interactive-surface-*` contract. | ||
| - Existing accessibility behavior remains unchanged for focus, pressed, disabled, reduced motion, high contrast, and forced colors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.