[Feature] ActionConfig - Granular Outcomes#1880
Conversation
| } | ||
|
|
||
| static addDamage(_event) { | ||
| static addDamage(_event, button) { |
There was a problem hiding this comment.
This is a general thing in the codebase, but do you mind if we rename actions like these to #onAddDamage? It differentiates from methods invoked to do things, and its also the convention used by the core foundry codebase.
There was a problem hiding this comment.
I suppose we could, although it does feel like becoming the villain of my own story.
In the case of Foundry, I detest the use of #. It's always the reason we end up needing to copy some 5 extra methods when we want to override just 1, as it's not possible to reference the private methods from outside.
In our case it's probably less of an issue though as our classes and dialogs aren't intended to be overwritten.
There was a problem hiding this comment.
the important thing is starting with on. If using # makes you uncomfortable we can avoid it. Let me know.
The main benefit of using # is being able to make changes without being concerned about something being part of a public interface. I am in agreement when functionality can't be replicated.
87a7a75 to
1af377b
Compare
…ote having metadata
* Fix visual quirk with blur in unfocused countdown * Snuck in fixes and refactors
* Preload ancestry and community features in description * Corrected comments --------- Co-authored-by: WBHarry <williambjrklund@gmail.com>
…er data is used over that in the levelup data if available (#1971)
* Made trigger errors more informative * .
* Fixed so that automated countdowns reverse progress from Fear when rerolling dice if the duality result changes * . * Removed overprep * Apply suggestion from @CarlosFdez --------- Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>
* . * . * Apply suggestion from @CarlosFdez --------- Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>
* Simplify ActiveEffect sheet tags * Show origin actor and exclude tag if it is a top level actor tag without origin
* Fixed so that damageParts without an applyTo field is assumed to be hitPoints * Added the applyTo field to the basic attack for Adversaries and Companions * Tentative blindfix to issues of entities being null. Can't replicate it * Added some safety for missing things if someone was on a REALLY old system version and then updated all the way * Moved v13 countdown migration over to a migrateData * .
* Fixed logic for picking which actor to summon * Moved getWorldActor function to utils and updated logic * . * Improved logic
3 participants
No description provided.