Skip to content

fix: bio/focusAreas renderizados + tests al nuevo copy#78

Merged
GMNAPI merged 1 commit into
masterfrom
fix/portfolio-bio-render-and-tests
Jun 30, 2026
Merged

fix: bio/focusAreas renderizados + tests al nuevo copy#78
GMNAPI merged 1 commit into
masterfrom
fix/portfolio-bio-render-and-tests

Conversation

@GMNAPI

@GMNAPI GMNAPI commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Arregla dos cosas que dejó el PR #77:

  1. Bio del hero seguía mostrando copy viejo. El Hero renderiza tPersonal('bio.full')messages.personal.bio, que NO se actualizó en content: reposiciona copy a Full-Stack Developer + IA (hero, about, SEO) y alinea VITA LIBER #77 (solo se cambió personal.ts, que alimenta el <title> SEO, no el render). Ahora messages.personal.bio.short/full y focusAreas (ES/EN) reflejan el perfil full-stack + IA.
  2. Tests en rojo (CI de content: reposiciona copy a Full-Stack Developer + IA (hero, about, SEO) y alinea VITA LIBER #77): 2 tests asertaban el tagline/about viejos, y el de bio asertaba el bio viejo. Actualizados los 3 a las nuevas cadenas:
    • Hero "render tagline" → /full-stack developer/i
    • Hero "render bio" → /desarrollador full-stack/i
    • About "render personal description" → /desarrollador full-stack con 6+ años/i

Verificación

  • next build: EXIT 0, 16/16. JSON válido, paridad ES↔EN. (Vitest se valida en CI — localmente no corre por node_modules de Windows.)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
desenvolupadormaster Ready Ready Preview, Comment Jun 30, 2026 11:41pm
dev-portfolio-lab Ready Ready Preview, Comment Jun 30, 2026 11:41pm

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the portfolio's bio and focus areas in both English and Spanish translation files, shifting the focus from a 'Tech Lead' role to a 'Full-Stack Developer' role with an emphasis on SaaS and applied AI. It also updates the corresponding tests to reflect these content changes. The review feedback correctly identifies that the newly added focus areas in the Spanish translation file (es.json) are left in English, and provides suggestions to translate them for proper localization consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +787 to +792
"Full-Stack Development",
"SaaS Architecture",
"REST API Design",
"Multi-tenant Systems",
"Applied AI (RAG, OpenAI)",
"CI/CD & DevOps",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Dado que este es el archivo de traducción al español (es.json), los nuevos elementos de focusAreas deberían estar traducidos al español para mantener la consistencia en la localización del portafolio.

Suggested change
"Full-Stack Development",
"SaaS Architecture",
"REST API Design",
"Multi-tenant Systems",
"Applied AI (RAG, OpenAI)",
"CI/CD & DevOps",
"Desarrollo Full-Stack",
"Arquitectura SaaS",
"Diseño de APIs REST",
"Sistemas Multi-tenant",
"IA Aplicada (RAG, OpenAI)",
"CI/CD y DevOps",

"Iterative Delivery",
"User Support & Training",
"Technical Strategy"
"Code Quality & Testing"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

De igual manera, este elemento de focusAreas debería estar traducido al español para mantener la consistencia en la localización.

Suggested change
"Code Quality & Testing"
"Calidad de Código y Testing"

@github-actions

Copy link
Copy Markdown

CI Pipeline passed! All checks completed successfully.

@GMNAPI GMNAPI merged commit 885cd66 into master Jun 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant