Skip to content

fix: bio/focusAreas renderizados + tests al nuevo copy #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GMNAPI merged 1 commit into from
Jun 30, 2026
Merged

fix: bio/focusAreas renderizados + tests al nuevo copy #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions apps/portfolio/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,21 +777,21 @@
},
"tagline": "Full-Stack Developer | Symfony · PHP | React/Next.js | Multi-tenant SaaS | Applied AI",
"bio": {
"short": "Tech Lead with experience collaborating with users and clients, clear communication and a solution-oriented attitude.",
"full": "Tech Lead specialized in translating business requirements into technical solutions. Experience leading teams, coordinating with stakeholders, and managing incidents with effective communication. Focused on delivering value through clear communication, task follow-up and iterative delivery."
"short": "Full-stack developer (Symfony/PHP, React/Next.js) specialized in production SaaS and applied AI.",
"full": "Full-stack developer with 6+ years building and shipping production SaaS. Backend with Symfony/PHP and API Platform, frontend with React/Next.js and TypeScript. Experience in multi-tenant architectures, payment integrations (Stripe), tax compliance (Veri*factu/AEAT) and applied AI (RAG, OpenAI). Focused on scalable architecture, clean code and quality."
},
"availability": {
"open": "Open to new opportunities"
},
"focusAreas": [
"Full-Stack Development",
"SaaS Architecture",
"REST API Design",
"Multi-tenant Systems",
"Applied AI (RAG, OpenAI)",
"CI/CD & DevOps",
"Technical Leadership",
"Stakeholder Communication",
"Requirements Analysis",
"Team Coordination",
"Incident Resolution",
"Iterative Delivery",
"User Support & Training",
"Technical Strategy"
"Code Quality & Testing"
]
},
"career": {}
Expand Down
18 changes: 9 additions & 9 deletions apps/portfolio/messages/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,21 +777,21 @@
},
"tagline": "Full-Stack Developer | Symfony · PHP | React/Next.js | SaaS multi-tenant | IA aplicada",
"bio": {
"short": "Tech Lead con experiencia colaborando con usuarios y clientes, comunicación clara y actitud resolutiva.",
"full": "Tech Lead especializado en traducir requisitos de negocio a soluciones técnicas. Experiencia liderando equipos, coordinando con stakeholders, y gestionando incidencias con comunicación efectiva. Enfocado en entregar valor a través de comunicación clara, seguimiento de tareas y entregas iterativas."
"short": "Desarrollador full-stack (Symfony/PHP, React/Next.js) especializado en SaaS en producción e IA aplicada.",
"full": "Desarrollador full-stack con 6+ años construyendo y desplegando SaaS en producción. Backend con Symfony/PHP y API Platform, frontend con React/Next.js y TypeScript. Experiencia en arquitecturas multi-tenant, integraciones de pago (Stripe), cumplimiento fiscal (Veri*factu/AEAT) e IA aplicada (RAG, OpenAI). Enfoque en escalabilidad, clean code y calidad."
},
"availability": {
"open": "Abierto a nuevas oportunidades"
},
"focusAreas": [
"Full-Stack Development",
"SaaS Architecture",
"REST API Design",
"Multi-tenant Systems",
"Applied AI (RAG, OpenAI)",
"CI/CD & DevOps",
Comment on lines +787 to +792

@gemini-code-assist gemini-code-assist Bot Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Dado que este es el archivo de traducción al español (es.json), los nuevos elementos de focusAreas deberían estar traducidos al español para mantener la consistencia en la localización del portafolio.

Suggested change
"Full-Stack Development",
"SaaS Architecture",
"REST API Design",
"Multi-tenant Systems",
"Applied AI (RAG, OpenAI)",
"CI/CD & DevOps",
"Desarrollo Full-Stack",
"Arquitectura SaaS",
"Diseño de APIs REST",
"Sistemas Multi-tenant",
"IA Aplicada (RAG, OpenAI)",
"CI/CD y DevOps",

"Technical Leadership",
"Stakeholder Communication",
"Requirements Analysis",
"Team Coordination",
"Incident Resolution",
"Iterative Delivery",
"User Support & Training",
"Technical Strategy"
"Code Quality & Testing"

@gemini-code-assist gemini-code-assist Bot Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

De igual manera, este elemento de focusAreas debería estar traducido al español para mantener la consistencia en la localización.

Suggested change
"Code Quality & Testing"
"Calidad de Código y Testing"

]
},
"career": {}
Expand Down
2 changes: 1 addition & 1 deletion apps/portfolio/tests/features/about/About.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('About Section', () => {

it('should render personal description', () => {
renderAbout();
expect(screen.getByText(/tech lead con experiencia colaborando/i)).toBeInTheDocument();
expect(screen.getByText(/desarrollador full-stack con 6\+ años/i)).toBeInTheDocument();
});

it('should render GitHub stats block', () => {
Expand Down
6 changes: 2 additions & 4 deletions apps/portfolio/tests/features/hero/Hero.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,14 @@ describe('Hero Section', () => {
renderHero();
expect(
screen.getByRole('heading', {
name: /tech lead.*comunicación técnica.*saas.*node\.js.*react.*php\/symfony/i,
name: /full-stack developer/i,
})
).toBeInTheDocument();
});

it('should render bio description', () => {
renderHero();
expect(
screen.getByText(/tech lead especializado en traducir requisitos/i)
).toBeInTheDocument();
expect(screen.getByText(/desarrollador full-stack/i)).toBeInTheDocument();
});

it('should render all CTA buttons', () => {
Expand Down
Loading