downgrade Dataset.publisher from mandatory to recommended and update examples#147
Merged
Merged
Conversation
…examples accordingly Changes: - change publisher 'requirementLevel' to 'Recommended' - remove publisher from 'required' array - update Catalog examples to remove Dataset.publisher where appropriate - update Dataset examples to remove publisher where appropriate - update Dataset examples to add identifier where appropriate (missed in a previous PR)
Author
|
I will run |
This upgraded click and urllib3, which had vulnerabilities that needed addressing. This should address them.
Collaborator
|
@zopalmer14 made the necessary security changes (added by default to all data.gov repo's recently), should be good to go there. |
jbrown-xentity
approved these changes
Jun 1, 2026
jbrown-xentity
left a comment
jbrown-xentity
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, seems accurate and the validation tests are passing. Just need to get the docs updated and this can be merged. Once merged, will apply to resources.data.gov documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve: #141
Changes:
publisher'requirementLevel' to 'Recommended'publisherfrom 'required' arrayCatalogexamples to removeDataset.publisherwhere appropriateDatasetexamples to removepublisherwhere appropriateDatasetexamples to addidentifierwhere appropriate (missed in a previous PR)