Skip to content

spectator view sharing other session objects#50

Merged
skim0119 merged 1 commit intometa2quest-integrationfrom
spectator-view
Apr 15, 2026
Merged

spectator view sharing other session objects#50
skim0119 merged 1 commit intometa2quest-integrationfrom
spectator-view

Conversation

@skim0119
Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 commented Apr 13, 2026

TL;DR

Added spectator and arm camera modes with new UI controls and session binding logic.

What changed?

  • Added new session modes: "spectator" and "arm_camera" with corresponding join buttons in the UI
  • Created session_bindings.js module with functions to handle arm binding logic for different camera modes
  • Implemented arm_camera_controller.js for controlling camera position based on arm states with smooth interpolation
  • Added spectator_avatar_manager.js to manage spectator avatar selection and rendering
  • Enhanced the main app with better code organization through comments and extracted session binding logic
  • Added arm camera panel with user and arm selection dropdowns

How to test?

  1. Load the VR client interface
  2. Click "Join as Spectator" to enter spectator mode and observe automatic arm following
  3. Click "Join Arm Camera" to enter arm camera mode
  4. In arm camera mode, use the new panel to select different users and arms
  5. Verify smooth camera transitions when switching between arms
  6. Test that head arms are properly filtered from selection options

Why make this change?

This change introduces new viewing modes for users who want to observe sessions without actively participating. The spectator mode automatically follows active users, while the arm camera mode provides precise control over which arm to follow with smooth camera movements. This enhances the collaborative experience by allowing observers and improves the overall usability of the VR system.

@skim0119 skim0119 marked this pull request as ready for review April 13, 2026 04:12
@skim0119 skim0119 force-pushed the 04-12-restructure_app_code_for_modularizing_and_organization branch from 9d9d51f to 6fe4b7e Compare April 15, 2026 01:52
@skim0119 skim0119 force-pushed the 04-12-restructure_app_code_for_modularizing_and_organization branch 2 times, most recently from d2774b8 to 67d797b Compare April 15, 2026 02:01
Copy link
Copy Markdown
Collaborator Author

skim0119 commented Apr 15, 2026

Merge activity

  • Apr 15, 2:11 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 15, 2:12 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 15, 2:13 AM UTC: @skim0119 merged this pull request with Graphite.

@skim0119 skim0119 changed the base branch from 04-12-restructure_app_code_for_modularizing_and_organization to graphite-base/50 April 15, 2026 02:11
@skim0119 skim0119 changed the base branch from graphite-base/50 to meta2quest-integration April 15, 2026 02:11
@skim0119 skim0119 merged commit 3362b71 into meta2quest-integration Apr 15, 2026
@skim0119 skim0119 deleted the spectator-view branch April 15, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant