Fix REF_PTR_SET macro self-assignment bug #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-2RY. The issue was that: Write access violation in
Render2DClass::Set_Texturedue tothis->Texturebeing a corrupted pointer whenRelease_Ref()is called.REF_PTR_SETmacro had a potential bug where assigning a pointer to itself (self-assignment) could lead to premature object deletion due to the order ofAdd_RefandRelease_Refcalls.dstpointer, ensuringRelease_Refis called on the old object afterAdd_Refis called on the new (or same) object, preventing a race condition or premature deletion during self-assignment.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9146331
Not quite right? Click here to continue debugging with Seer.