Skip to content

Conversation

@seer-by-sentry
Copy link

Fixes CLIENT-2RY. The issue was that: Write access violation in Render2DClass::Set_Texture due to this->Texture being a corrupted pointer when Release_Ref() is called.

  • The REF_PTR_SET macro had a potential bug where assigning a pointer to itself (self-assignment) could lead to premature object deletion due to the order of Add_Ref and Release_Ref calls.
  • The fix introduces a temporary variable to store the original dst pointer, ensuring Release_Ref is called on the old object after Add_Ref is called on the new (or same) object, preventing a race condition or premature deletion during self-assignment.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9146331

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants