Skip to content

Fix REF_PTR_SET macro self-assignment bug #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix REF_PTR_SET macro self-assignment bug #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Libraries/Source/WWVegas/WWLib/refcount.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ struct ActiveRefStruct
** you want to point it at some object. You must release whatever it currently points at,
** point it at the new object, and add-ref the new object (if its not null...)
*/
#define REF_PTR_SET(dst,src) { if (src) (src)->Add_Ref(); if (dst) (dst)->Release_Ref(); (dst) = (src); }
#define REF_PTR_SET(dst,src) { auto _ref_tmp = (dst); (dst) = (src); if (src) (src)->Add_Ref(); if (_ref_tmp) (_ref_tmp)->Release_Ref(); }
#define REF_PTR_RELEASE(x) { if (x) x->Release_Ref(); x = nullptr; }


Expand Down
Loading