[Fixes #14158] Fixes export of tabular dataset#14159
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the can_have_wfs_links property in geonode/base/models.py to include the tabular subtype. Feedback suggests also including the vector_time subtype to maintain consistency with other properties and ensure that vector time resources, which are served via WFS, correctly support WFS links.
| @property | ||
| def can_have_wfs_links(self): | ||
| return self.subtype == "vector" | ||
| return self.subtype in {"vector", "tabular"} |
There was a problem hiding this comment.
While adding tabular support is correct for fixing the export of tabular datasets, vector_time should also be included in can_have_wfs_links. vector_time is a vector subtype (as defined in Dataset.is_vector) and resources of this type are served via WFS by GeoServer, thus they should support WFS links for export and download. This ensures consistency with can_be_downloaded and can_have_wps_links which already include vector_time.
| return self.subtype in {"vector", "tabular"} | |
| return self.subtype in {"vector", "vector_time", "tabular"} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14159 +/- ##
==========================================
- Coverage 74.62% 74.55% -0.07%
==========================================
Files 958 958
Lines 57891 58043 +152
Branches 7889 7920 +31
==========================================
+ Hits 43202 43276 +74
- Misses 12927 13000 +73
- Partials 1762 1767 +5 🚀 New features to boost your workflow:
|
Fixes #14158
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.