Skip to content

[Fixes #14158] Fixes export of tabular dataset #14159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattiagiupponi merged 1 commit into from
Apr 23, 2026
+1 −1
Merged

[Fixes #14158] Fixes export of tabular dataset #14159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geonode/base/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ def can_be_downloaded(self):

@property
def can_have_wfs_links(self):
return self.subtype == "vector"
return self.subtype in {"vector", "tabular"}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding tabular support is correct for fixing the export of tabular datasets, vector_time should also be included in can_have_wfs_links. vector_time is a vector subtype (as defined in Dataset.is_vector) and resources of this type are served via WFS by GeoServer, thus they should support WFS links for export and download. This ensures consistency with can_be_downloaded and can_have_wps_links which already include vector_time.

Suggested change
return self.subtype in {"vector", "tabular"}
return self.subtype in {"vector", "vector_time", "tabular"}


@property
def can_have_wps_links(self):
Expand Down
Loading