Skip to content

feat(ui): new spinner for next page loading#2549

Open
Brazol wants to merge 1 commit intofeat/design-refreshfrom
feat/new-spinner
Open

feat(ui): new spinner for next page loading#2549
Brazol wants to merge 1 commit intofeat/design-refreshfrom
feat/new-spinner

Conversation

@Brazol
Copy link
Contributor

@Brazol Brazol commented Mar 19, 2026

Submit a pull request

Linear: FLU-397

Core component: GetStream/stream-core-flutter#77

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Screenshots / Videos

Before After
before after

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4025e700-e0c6-49c1-b75d-99545e6e4cad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/new-spinner
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.57%. Comparing base (1acb695) to head (89fcec5).

Files with missing lines Patch % Lines
.../channel_scroll_view/stream_channel_grid_view.dart 0.00% 2 Missing ⚠️
.../channel_scroll_view/stream_channel_list_view.dart 0.00% 2 Missing ⚠️
...view/draft_scroll_view/stream_draft_list_view.dart 0.00% 2 Missing ⚠️
...ew/member_scroll_view/stream_member_grid_view.dart 0.00% 2 Missing ⚠️
...ew/member_scroll_view/stream_member_list_view.dart 0.00% 2 Missing ⚠️
...h_scroll_view/stream_message_search_grid_view.dart 0.00% 2 Missing ⚠️
...h_scroll_view/stream_message_search_list_view.dart 0.00% 2 Missing ⚠️
...croll_view/photo_gallery/stream_photo_gallery.dart 0.00% 2 Missing ⚠️
...l_vote_scroll_view/stream_poll_vote_list_view.dart 0.00% 2 Missing ⚠️
...eaction_scroll_view/stream_reaction_list_view.dart 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feat/design-refresh    #2549      +/-   ##
=======================================================
- Coverage                64.63%   64.57%   -0.06%     
=======================================================
  Files                      426      425       -1     
  Lines                    26098    26120      +22     
=======================================================
- Hits                     16869    16868       -1     
- Misses                    9229     9252      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -375 to +376
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we don't want to make the padding part of the spinner if we have it (almost) everywhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I also wonder if the StreamLoadingSpinner can't have a const constructor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants