feat(ui): new spinner for next page loading#2549
feat(ui): new spinner for next page loading#2549Brazol wants to merge 1 commit intofeat/design-refreshfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/design-refresh #2549 +/- ##
=======================================================
- Coverage 64.63% 64.57% -0.06%
=======================================================
Files 426 425 -1
Lines 26098 26120 +22
=======================================================
- Hits 16869 16868 -1
- Misses 9229 9252 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| padding: EdgeInsets.all(16), | ||
| child: StreamScrollViewLoadMoreIndicator(), | ||
| padding: const EdgeInsets.all(16), | ||
| child: StreamLoadingSpinner(), |
There was a problem hiding this comment.
I wonder if we don't want to make the padding part of the spinner if we have it (almost) everywhere.
There was a problem hiding this comment.
btw, I also wonder if the StreamLoadingSpinner can't have a const constructor?
Submit a pull request
Linear: FLU-397
Core component: GetStream/stream-core-flutter#77
CLA
Description of the pull request
Screenshots / Videos