Skip to content

feat(ui): new spinner for next page loading #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brazol wants to merge 1 commit into
base: feat/design-refresh
Choose a base branch
from
+53 −54
Open

feat(ui): new spinner for next page loading #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion melos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ command:
stream_core_flutter:
git:
url: https://github.com/GetStream/stream-core-flutter.git
ref: c7a31449e8632ea43f8c769be95a30ef9393a792
ref: 2773de5eb126f3cd1f12114f1cb83173155ee8cd
path: packages/stream_core_flutter
synchronized: ^3.1.0+1
thumblr: ^0.0.4
Expand Down
8 changes: 4 additions & 4 deletions ...stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_grid_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default grid delegate for [StreamChannelGridView].
const defaultChannelGridViewDelegate = SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 4);
Expand Down Expand Up @@ -370,10 +370,10 @@ class StreamChannelGridView extends StatelessWidget {
textAlign: TextAlign.center,
),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamChannelListView].
Widget defaultChannelListViewSeparatorBuilder(
Expand Down Expand Up @@ -341,10 +341,10 @@ class StreamChannelListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingChannelsError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...ges/stream_chat_flutter/lib/src/scroll_view/draft_scroll_view/stream_draft_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamDraftListView].
Widget defaultDraftListViewSeparatorBuilder(
Expand Down Expand Up @@ -333,10 +333,10 @@ class StreamDraftListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingMessagesError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...s/stream_chat_flutter/lib/src/scroll_view/member_scroll_view/stream_member_grid_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default grid delegate for [StreamMemberGridView].
const defaultMemberGridViewDelegate = SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 4);
Expand Down Expand Up @@ -370,10 +370,10 @@ class StreamMemberGridView extends StatelessWidget {
textAlign: TextAlign.center,
),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
Comment on lines -375 to +376
Copy link
Contributor

@renefloor renefloor Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we don't want to make the padding part of the spinner if we have it (almost) everywhere.

Copy link
Contributor

@renefloor renefloor Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I also wonder if the StreamLoadingSpinner can't have a const constructor?

),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...s/stream_chat_flutter/lib/src/scroll_view/member_scroll_view/stream_member_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamMemberListView].
Widget defaultMemberListViewSeparatorBuilder(
Expand Down Expand Up @@ -337,10 +337,10 @@ class StreamMemberListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingUsersError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...utter/lib/src/scroll_view/message_search_scroll_view/stream_message_search_grid_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default grid delegate for [StreamMessageSearchGridView].
const defaultMessageSearchGridViewDelegate = SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 4);
Expand Down Expand Up @@ -338,10 +338,10 @@ class StreamMessageSearchGridView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingMessagesError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...utter/lib/src/scroll_view/message_search_scroll_view/stream_message_search_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamMessageSearchListView].
Widget defaultMessageSearchListViewSeparatorBuilder(
Expand Down Expand Up @@ -340,10 +340,10 @@ class StreamMessageSearchListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingMessagesError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions packages/stream_chat_flutter/lib/src/scroll_view/photo_gallery/stream_photo_gallery.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import 'package:photo_manager/photo_manager.dart' show AssetEntity, ThumbnailFor

import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default grid delegate for [StreamPhotoGallery].
const defaultStreamPhotoGalleryDelegate = SliverGridDelegateWithFixedCrossAxisCount(
Expand Down Expand Up @@ -382,10 +382,10 @@ class StreamPhotoGallery extends StatelessWidget {
);
},
loadMoreIndicatorBuilder: (context) {
return const Center(
return Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
);
},
Expand Down
7 changes: 3 additions & 4 deletions ...am_chat_flutter/lib/src/scroll_view/poll_vote_scroll_view/stream_poll_vote_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_empty_wid
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_indexed_widget_builder.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/src/theme/stream_chat_theme.dart';
import 'package:stream_chat_flutter/src/utils/extensions.dart';
Expand Down Expand Up @@ -343,10 +342,10 @@ class StreamPollVoteListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingPollVotesError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions ...ream_chat_flutter/lib/src/scroll_view/reaction_scroll_view/stream_reaction_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamReactionListView].
Widget defaultReactionListViewSeparatorBuilder(
Expand Down Expand Up @@ -205,10 +205,10 @@ class StreamReactionListView extends StatelessWidget {
onTap: controller.retry,
error: const Text('Error loading reactions'),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) => loadingBuilder?.call(context) ?? const Center(child: StreamScrollViewLoadingWidget()),
Expand Down
8 changes: 4 additions & 4 deletions ...s/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamThreadListView].
Widget defaultThreadListViewSeparatorBuilder(
Expand Down Expand Up @@ -333,10 +333,10 @@ class StreamThreadListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingMessagesError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions packages/stream_chat_flutter/lib/src/scroll_view/user_scroll_view/stream_user_grid_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default grid delegate for [StreamUserGridView].
const defaultUserGridViewDelegate = SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 4);
Expand Down Expand Up @@ -367,10 +367,10 @@ class StreamUserGridView extends StatelessWidget {
textAlign: TextAlign.center,
),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
8 changes: 4 additions & 4 deletions packages/stream_chat_flutter/lib/src/scroll_view/user_scroll_view/stream_user_list_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_error_widget.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_error.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_load_more_indicator.dart';
import 'package:stream_chat_flutter/src/scroll_view/stream_scroll_view_loading_widget.dart';
import 'package:stream_chat_flutter/stream_chat_flutter.dart';
import 'package:stream_core_flutter/stream_core_flutter.dart';

/// Default separator builder for [StreamUserListView].
Widget defaultUserListViewSeparatorBuilder(
Expand Down Expand Up @@ -337,10 +337,10 @@ class StreamUserListView extends StatelessWidget {
onTap: controller.retry,
error: Text(context.translations.loadingUsersError),
),
loadMoreIndicatorBuilder: (context) => const Center(
loadMoreIndicatorBuilder: (context) => Center(
child: Padding(
padding: EdgeInsets.all(16),
child: StreamScrollViewLoadMoreIndicator(),
padding: const EdgeInsets.all(16),
child: StreamLoadingSpinner(),
),
),
loadingBuilder: (context) =>
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_chat_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ dependencies:
stream_core_flutter:
git:
url: https://github.com/GetStream/stream-core-flutter.git
ref: c7a31449e8632ea43f8c769be95a30ef9393a792
ref: 2773de5eb126f3cd1f12114f1cb83173155ee8cd
path: packages/stream_core_flutter
svg_icon_widget: ^0.0.1
synchronized: ^3.1.0+1
Expand Down
Loading