Skip to content

feat(ui): loading spinner component#77

Merged
Brazol merged 4 commits intomain-design-systemfrom
feat/loading-spinner-component
Mar 19, 2026
Merged

feat(ui): loading spinner component#77
Brazol merged 4 commits intomain-design-systemfrom
feat/loading-spinner-component

Conversation

@Brazol
Copy link
Contributor

@Brazol Brazol commented Mar 19, 2026

Submit a pull request

Linear: FLU-397

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Screenshots / Videos

spinner.mov

@Brazol Brazol requested a review from a team as a code owner March 19, 2026 08:30
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 48b35c6a-f909-4cdf-97f3-6d79a113f35c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/loading-spinner-component
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main-design-system@c7a3144). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../src/components/common/stream_loading_spinner.dart 0.00% 53 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             main-design-system      #77   +/-   ##
=====================================================
  Coverage                      ?   28.76%           
=====================================================
  Files                         ?      135           
  Lines                         ?     4506           
  Branches                      ?        0           
=====================================================
  Hits                          ?     1296           
  Misses                        ?     3210           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@renefloor renefloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a component theme for the loading spinner, but we can also add it later.

@Brazol Brazol merged commit 229240b into main-design-system Mar 19, 2026
3 of 4 checks passed
@Brazol Brazol deleted the feat/loading-spinner-component branch March 19, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants