Provide MainActivityAlias by AppInfoProvider#192
Merged
Conversation
Goooler
force-pushed
the
provide-main-alias
branch
from
9b24f4a to
987ad18
Compare
Goooler
force-pushed
the
provide-main-alias
branch
from
987ad18 to
18afe41
Compare
There was a problem hiding this comment.
Pull request overview
This PR centralizes knowledge about the app’s main activity entry points by introducing an AppInfoProvider (backed by Koin) and migrating call sites that previously hardcoded or locally provided the main activity class / alias.
Changes:
- Replaced the old
MainActivityClassProviderlookup inmainIntent()withAppInfoProvider.instance. - Moved
Context.mainActivityAliasfromUiStore’s companion to a shared util extension backed byAppInfoProvider. - Wired
AppInfoProviderinto the app’s Koin module and updated settings VM imports accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/settings/src/main/kotlin/com/github/kr328/clash/settings/vm/AppSettingsViewModel.kt | Switches to the new mainActivityAlias import location. |
| glue/src/main/kotlin/com/github/kr328/clash/util/Intent.kt | Uses AppInfoProvider for mainIntent() and introduces Koin-backed Context.mainActivityAlias. |
| glue/src/main/kotlin/com/github/kr328/clash/store/UiStore.kt | Removes the old hardcoded alias extension and imports the new util-based alias. |
| glue/src/main/kotlin/com/github/kr328/clash/di/AppInfoProvider.kt | Adds the Koin-resolved provider interface used across modules. |
| app/src/main/kotlin/com/github/kr328/clash/AppModule.kt | Registers AppInfoProvider in Koin and defines the alias string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+14
| val Context.mainActivityAlias: ComponentName | ||
| get() = ComponentName(this, appInfoProvider.mainActivityAlias) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.