Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/src/main/kotlin/com/github/kr328/clash/AppModule.kt
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package com.github.kr328.clash

import android.app.Activity
import com.github.kr328.clash.util.MainActivityClassProvider
import com.github.kr328.clash.di.AppInfoProvider
import org.koin.dsl.module

val appModule = module { single<MainActivityClassProvider> { MainActivityClassProviderImpl } }
val appModule = module { single<AppInfoProvider> { AppInfoProviderImpl } }

private object MainActivityClassProviderImpl : MainActivityClassProvider {
private object AppInfoProviderImpl : AppInfoProvider {
override val mainActivityClass: Class<out Activity> = MainActivity::class.java
override val mainActivityAlias: String = "${MainActivity::class.qualifiedName}Alias"
Comment thread
Goooler marked this conversation as resolved.
}
14 changes: 14 additions & 0 deletions glue/src/main/kotlin/com/github/kr328/clash/di/AppInfoProvider.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.github.kr328.clash.di

import android.app.Activity
import org.koin.core.component.KoinComponent
import org.koin.core.component.inject

interface AppInfoProvider {
val mainActivityClass: Class<out Activity>
val mainActivityAlias: String

companion object : KoinComponent {
val instance: AppInfoProvider by inject()
}
}
5 changes: 1 addition & 4 deletions glue/src/main/kotlin/com/github/kr328/clash/store/UiStore.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.github.kr328.clash.store

import android.content.ComponentName
import android.content.Context
import android.content.SharedPreferences.OnSharedPreferenceChangeListener
import android.content.pm.PackageManager
Expand All @@ -11,6 +10,7 @@ import com.github.kr328.clash.common.util.unsafeLazy
import com.github.kr328.clash.core.model.ProxySort
import com.github.kr328.clash.model.AppInfo
import com.github.kr328.clash.model.DarkMode
import com.github.kr328.clash.util.mainActivityAlias
import kotlinx.coroutines.channels.awaitClose
Comment thread
Goooler marked this conversation as resolved.
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
Expand Down Expand Up @@ -110,8 +110,5 @@ class UiStore(context: Context) {

companion object {
private const val PREFERENCE_NAME = "ui"

val Context.mainActivityAlias: ComponentName
get() = ComponentName(this, "com.github.kr328.clash.MainActivityAlias")
}
}
13 changes: 6 additions & 7 deletions glue/src/main/kotlin/com/github/kr328/clash/util/Intent.kt
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
package com.github.kr328.clash.util

import android.app.Activity
import android.content.ComponentName
import android.content.Context
import android.content.Intent
import org.koin.mp.KoinPlatform

interface MainActivityClassProvider {
val mainActivityClass: Class<out Activity>
}
import com.github.kr328.clash.di.AppInfoProvider.Companion.instance as appInfoProvider

fun mainIntent(context: Context, action: String? = null): Intent {
val mainActivityClass = KoinPlatform.getKoin().get<MainActivityClassProvider>().mainActivityClass
val mainActivityClass = appInfoProvider.mainActivityClass
return Intent(context, mainActivityClass).setAction(action)
}

val Context.mainActivityAlias: ComponentName
get() = ComponentName(this, appInfoProvider.mainActivityAlias)
Comment on lines +13 to +14
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import com.github.kr328.clash.model.DarkMode
import com.github.kr328.clash.remote.Remote
import com.github.kr328.clash.service.store.ServiceStore
import com.github.kr328.clash.store.UiStore
import com.github.kr328.clash.store.UiStore.Companion.mainActivityAlias
import com.github.kr328.clash.util.ApplicationObserver
import com.github.kr328.clash.util.mainActivityAlias
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.update
Expand Down