Ensure forward compatibility with ipl-sql by adding return types#269
Merged
Ensure forward compatibility with ipl-sql by adding return types#269
ipl-sql by adding return types#269Conversation
BastianLedererIcinga
previously approved these changes
Feb 27, 2026
sukhwinder33445
force-pushed
the
fix/compat-with-ipl-sql-Connection-class
branch
from
50202d9 to
d8c8a26
Compare
sukhwinder33445
force-pushed
the
fix/compat-with-ipl-sql-Connection-class
branch
from
d8c8a26 to
41eb2f3
Compare
sukhwinder33445
changed the title
RetryConnection: Make class compatible with ipl\Sql\Connection
sukhwinder33445
force-pushed
the
fix/compat-with-ipl-sql-Connection-class
branch
from
41eb2f3 to
b90c97c
Compare
BastianLedererIcinga
previously approved these changes
Mar 6, 2026
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
Tested with ipl main and modernize branches, both works fine.
lippserd
requested changes
Mar 19, 2026
| class RetryConnection extends Connection | ||
| { | ||
| public function prepexec($stmt, $values = null) | ||
| public function prepexec($stmt, $values = null): false|PDOStatement |
Member
There was a problem hiding this comment.
Suggested change
| public function prepexec($stmt, $values = null): false|PDOStatement | |
| public function prepexec($stmt, $values = null): PDOStatement|false |
sukhwinder33445
force-pushed
the
fix/compat-with-ipl-sql-Connection-class
branch
2 times, most recently
from
f55f072 to
8522ce5
Compare
sukhwinder33445
force-pushed
the
fix/compat-with-ipl-sql-Connection-class
branch
from
8522ce5 to
b397e1e
Compare
lippserd
changed the title
ipl-sql by adding return types
lippserd
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit return types to
ipl-sql-derived methods to prepare for stricttyping. These additions are safe, as they only annotate existing methods that
previously lacked return type declarations.
refs Icinga/ipl-sql#100