Skip to content

Ensure forward compatibility with ipl-sql by adding return types #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lippserd merged 2 commits into from
Mar 23, 2026
Merged

Ensure forward compatibility with ipl-sql by adding return types #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b397e1e
RetryConnection: Ensure ipl forward compatibility
sukhwinder33445 Feb 27, 2026
c61ab8b
Simplify FQN
sukhwinder33445 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions library/Reporting/RetryConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@

namespace Icinga\Module\Reporting;

use Exception;
use ipl\Sql\Connection;
use PDOStatement;

class RetryConnection extends Connection
{
public function prepexec($stmt, $values = null)
public function prepexec($stmt, $values = null): PDOStatement
{
try {
$sth = parent::prepexec($stmt, $values);
} catch (\Exception $e) {
} catch (Exception $e) {
$lostConnection = Str::contains($e->getMessage(), [
'server has gone away',
'no connection to the server',
Expand Down Expand Up @@ -45,7 +47,7 @@ public function prepexec($stmt, $values = null)

try {
$this->connect();
} catch (\Exception $e) {
} catch (Exception $e) {
$noConnection = Str::contains($e->getMessage(), [
'No such file or directory',
'Connection refused'
Expand All @@ -55,7 +57,7 @@ public function prepexec($stmt, $values = null)
throw $e;
}

\sleep(10);
sleep(10);

$this->connect();
}
Expand Down
Loading