Test task#42
Open
bez-borody wants to merge 8 commits into
Open
Conversation
IlyaOrlov
reviewed
Sep 13, 2022
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
Начало положено) Жду ещё файлов с решениями д/з.
IlyaOrlov
requested changes
Sep 14, 2022
| @@ -0,0 +1,9 @@ | |||
| import math | |||
| def square(r): | |||
Owner
There was a problem hiding this comment.
Согласно PEP8 определение функции (стр.2-3) должно быть отделено от остального кода (сверху и снизу) двумя пустыми строками.
IlyaOrlov
reviewed
Sep 14, 2022
IlyaOrlov
requested changes
Sep 20, 2022
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
ОК. Но одно замечание добавилось.
IlyaOrlov
reviewed
Sep 21, 2022
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
С PEP8 всё ОК. Но по остальным файлам замечания тоже нужно поправить.
IlyaOrlov
reviewed
Sep 22, 2022
| end = input("Топлива осталось: ") | ||
| distance = input("Расстояние: ") | ||
| diff = int(start) - int(end) | ||
| result = int(diff) / int(distance) |
Owner
There was a problem hiding this comment.
С distance теперь всё верно, но diff-то и так число (т.к. это разность двух целых чисел), к нему int() применять не нужно.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.