Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Practice/Bezborody/lec1_task1.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
print("Hello1")
6 changes: 6 additions & 0 deletions Practice/Bezborody/lec1_task2.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
start = input("Топлива было: ")
end = input("Топлива осталось: ")
distance = input("Расстояние: ")
diff = int(start) - int(end)
result = int(diff) / int(distance)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С distance теперь всё верно, но diff-то и так число (т.к. это разность двух целых чисел), к нему int() применять не нужно.

print (f"Расход топлива {result}")
3 changes: 3 additions & 0 deletions Practice/Bezborody/lec1_task4.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
name = input("Введите имя: ")
fullname = input("Введите фамилию: ")
print(f"Echo: {name} {fullname}")
10 changes: 10 additions & 0 deletions Practice/Bezborody/lec2_task1.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import math
def square(r):
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Согласно PEP8 определение функции (стр.2-3) должно быть отделено от остального кода (сверху и снизу) двумя пустыми строками.

return math.pi * r ** 2

radius = input("Введите радиус: ")
result = square(int(radius))
print(f"Площадь круга: {result}")



69 changes: 69 additions & 0 deletions Practice/Bezborody/pep8task.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import sys
import os
import hashlib
import ast
import argparse
from time import * # такой import не рекомендуется PEP8


class shuffler: # нарушено правило CamelCase

def __init__(self):
self.map = {}

def rename(self, dirname, output):
mp3s = []
for root, directories, files in os.walk(dirname):
for file in files:
if file[-3:] == '.mp3':
mp3s.append([root, file])
for path, mp3 in mp3s:
hashname = self.generateName() + '.mp3'
self.map[hashname] = mp3
os.rename(path + '/' + mp3), path + '/' + hashname))
f = open(output, 'r') # нарушение уровней вложенности (2 пробела вместо 4)
f.write(str(self.map)) # тоже нарушены уровни вложенности

def restore(self, dirname, restore_path):
with open(filename, '+') as f: #уровни вложенности
self.map = ast.literal_eval(f.read()) # уровни вложенности
mp3s = [] # уровни вложенности
for root, directories, files in os.walk(dirname):
for file in files:
if file[-3:] == '.mp3': # уровни вложенности
mp3s.append({root, file}) # уровни вложенности
for path, hashname in mp3s:
os.rename(path + '/' + hashname, path + '/' + self.map[hashname])) # лишняя скобка
os.remove(restore_path)

def generateName(self, seed=time()): # уровни вложенности + generate и name дожны быть набраны через snake case
return hashlib.md5(str(seed)).hexdigest()


def parse_arguments():
parser = argparse.ArgumentParser()
subparsers = parser.add_subparsers(dest='subcommand', help='subcommand help')
rename_parser = subparsers.add_parser('rename', help='rename help')
rename_parser.add_argument('dirname')
rename_parser.add_argument('-o', '--output', help='path to a file where restore map is stored')
restore_parser = subparsers.add_parser('restore', help="command_a help")
restore_parser.add_argument('dirname')
restore_parser.add_argument('restore_map')
args = parser.parse_args()
return args

def main():
args = parse_arguments()
Shuffler = shuffler()
if args.subcommand == 'rename':
if args.output:
Shuffler.rename(args.dirname, 'restore.info')
else:
Shuffler.rename(args.dirname, args.output)
elif args.subcommand == 'restore':
Shuffler.restore(args.dirname, args.restore_map)
else:
sys.exit()


main()