refactor(runner): resolve container type before .bin validation#3430
Merged
refactor(runner): resolve container type before .bin validation#3430
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors runner/runc.sh so the container type is auto-resolved (alpine vs nixos) before .bin compatibility validation runs, ensuring the validator sees the concrete container type and applies the correct symlink rules under auto-detect.
Changes:
- Resolve empty
CONTAINER_TYPEearly based on host/nixpresence. - Add explicit
alpinehandling inselect_image()(base image, tag, and/nixmount) and remove the prior “empty means auto-detect” branch there. - Update the unknown container type error message to include
alpine.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolve empty CONTAINER_TYPE to alpine/nixos so the validator sees the concrete type and the nixos symlink check fires under auto-detect.
mkoura
force-pushed
the
explicit_container_type
branch
from
9e99f5e to
200c241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve empty CONTAINER_TYPE to alpine/nixos so the validator sees the concrete type and the nixos symlink check fires under auto-detect.